Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test specs for e4s 23.05 and 23.08. #242

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Conversation

wspear
Copy link
Collaborator

@wspear wspear commented Dec 13, 2023

Fixed input parsing for testgen script (needed a 3rd argument, only checked for the first 2).

Copy link
Contributor

@shahzebsiddiqui shahzebsiddiqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add the template file and package list so we can see what packages were added.

@@ -0,0 +1,26 @@
#This buildtest was generated from spack-test-23.05-template.yaml
buildspecs:
py-warpx_spack-test_23.05:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this test we dont have this installed in the gcc spack environment for e4s/23.05 i just checked

siddiq90@login27> spack -e gcc find py-warpx
==> No package matches the query: py-warpx

@shahzebsiddiqui
Copy link
Contributor

@wspear hold up i just realized we have spack tests for 23.08 in this PR #240 take a look at https://github.com/buildtesters/buildtest-nersc/tree/devel/buildspecs/e4s/spack_test/perlmutter. I see we have 23.05 tests too. I guess if you see any packages we have missed, we can add them.

@wspear
Copy link
Collaborator Author

wspear commented Dec 14, 2023

Yeah, I thought that was already all done. I thought the spack_test path was for the spack internal tests so I didn't look for the e4s testsuite tests there before making the new PR.

@shahzebsiddiqui
Copy link
Contributor

Yeah, I thought that was already all done. I thought the spack_test path was for the spack internal tests so I didn't look for the e4s testsuite tests there before making the new PR.

I think lets close this PR and you can work on E4S Testsuite tests for these stacks see issue #203. So only add test s for ones that have tests from E4S Testsuite. I dont know if there is an overlap with tests from spack test and E4S Testsuite for package X. If that is the case just simply skip from E4S Testsuite unless we see failure from spack test.

Right now there are 50 failures see https://my.cdash.org/viewTest.php?onlyfailed&buildid=2452793 so its not looking good and we may want to resort to E4S Testsuite for some of these

#This buildtest was generated from spack-test-23.05-template.yaml
buildspecs:
aml_e4s-testsuite_23.05:
type: spack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to script

@shahzebsiddiqui shahzebsiddiqui merged commit 8996285 into devel Dec 19, 2023
0 of 2 checks passed
@shahzebsiddiqui shahzebsiddiqui deleted the e4s-23-05/08 branch December 19, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants