Correctly handle lake_option=3 / no DA case#808
Merged
Conversation
rcabell
force-pushed
the
fix/lake-option-3-without-da
branch
from
16235fc to
15969a9
Compare
rcabell
force-pushed
the
fix/lake-option-3-without-da
branch
from
15969a9 to
dc7ea21
Compare
scrasmussen
approved these changes
Jan 27, 2025
Member
scrasmussen
left a comment
scrasmussen
left a comment
There was a problem hiding this comment.
LGTM! Arezoo tested the changes and confirmed they worked.
islas
pushed a commit
to wrf-model/WRF
that referenced
this pull request
Apr 1, 2025
…PR#808 (#2182) TYPE: bugfix KEYWORDS: hydro, bugfix, lake_option, reservoir DA SOURCE: Soren Rasmussen, internal hydro group DESCRIPTION OF CHANGES: Problem: If lake_option was set to 3 (Reservoir DA) but no Reservoir DA flags were set to .true. the internal lake_option was not set to [levelpool/off/passthrough] and a cryptic error resulted. Solution: NCAR/wrf_hydro_nwm_public#808 This fix now prints an error message and reverts the value to Level Pool if no DA option is selected. LIST OF MODIFIED FILES: ``` M hydro/OrchestratorLayer/config.F90 ``` TESTS CONDUCTED: 1. Do mods fix problem? Yes, tested in the WRF-Hydro model. WRF builds with GNU 3. Are the Jenkins tests all passing? Yes RELEASE NOTE: Hydro reservoir drainage area (DA) lake option bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: reservoir,da
SOURCE: NCAR
DESCRIPTION OF CHANGES:
If
lake_optionwas set to 3 (Reservoir DA) but no Reservoir DA flags were set to.true.the internal lake_option was not set to [levelpool/off/passthrough] and a cryptic error resulted. This fix now prints an error message and reverts the value to Level Pool if no DA option is selected.