forked from ufs-community/ufs-weather-model
-
Notifications
You must be signed in to change notification settings - Fork 7
UFS-dev PR#65 #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
UFS-dev PR#65 #99
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6c7d5d4
Dycore semi-implicit solver update (#1720)
XiaqiongZhou-NOAA 3343326
update FV3 to better handle data source for regional model LBC proces…
Jili-Dong ee35891
Cloud Dependencies for Regression Testing (#1667)
zach1221 eda0b07
PBL, Convection and Microphysics Update for HR2 (#1731)
Qingfu-Liu 3d5967b
Merge commit 'eda0b07' into ufs-dev-PR65
grantfirl 52ce3eb
update .gitmodules for testing
grantfirl c0e6d46
Merge branch 'main' into ufs-dev-PR65
grantfirl 1267803
add successful Hera/gnu RT log
grantfirl 84ef00e
add successful Hera/intel RT log
grantfirl bc8923b
add successful cheyenne/intel RT log
d40a1f0
add successful Cheyenne/GNU log
1e4a3d1
update FV3 submodule and revert .gitmodules
grantfirl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule WW3
updated
3 files
| +14 −14 | model/bin/ww3_from_ftp.sh | |
| +6 −4 | model/src/w3iorsmd.F90 | |
| +119 −120 | regtests/bin/run_cmake_test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| help([[ | ||
| loads UFS Model common libraries | ||
| ]]) | ||
|
|
||
| jasper_ver=os.getenv("jasper_ver") or "2.0.32" | ||
| load(pathJoin("jasper", jasper_ver)) | ||
|
|
||
| zlib_ver=os.getenv("zlib_ver") or "1.2.13" | ||
| load(pathJoin("zlib", zlib_ver)) | ||
|
|
||
| libpng_ver=os.getenv("libpng_ver") or "1.6.37" | ||
| load(pathJoin("libpng", libpng_ver)) | ||
|
|
||
| hdf5_ver=os.getenv("hdf5_ver") or "1.14.0" | ||
| load(pathJoin("hdf5", hdf5_ver)) | ||
|
|
||
| netcdf_ver=os.getenv("netcdf_ver") or "4.9.0" | ||
| load(pathJoin("netcdf-c", netcdf_ver)) | ||
| load(pathJoin("netcdf-fortran", "4.6.0")) | ||
|
|
||
| pio_ver=os.getenv("pio_ver") or "2.5.9" | ||
| load(pathJoin("parallelio", pio_ver)) | ||
|
|
||
| esmf_ver=os.getenv("esmf_ver") or "8.3.0b09" | ||
| load(pathJoin("esmf", esmf_ver)) | ||
|
|
||
| fms_ver=os.getenv("fms_ver") or "2022.04" | ||
| load(pathJoin("fms",fms_ver)) | ||
|
|
||
| bacio_ver=os.getenv("bacio_ver") or "2.4.1" | ||
| load(pathJoin("bacio", bacio_ver)) | ||
|
|
||
| crtm_ver=os.getenv("crtm_ver") or "2.4.0" | ||
| load(pathJoin("crtm", crtm_ver)) | ||
|
|
||
| g2_ver=os.getenv("g2_ver") or "3.4.5" | ||
| load(pathJoin("g2", g2_ver)) | ||
|
|
||
| g2tmpl_ver=os.getenv("g2tmpl_ver") or "1.10.2" | ||
| load(pathJoin("g2tmpl", g2tmpl_ver)) | ||
|
|
||
| ip_ver=os.getenv("ip_ver") or "3.3.3" | ||
| load(pathJoin("ip", ip_ver)) | ||
|
|
||
| sp_ver=os.getenv("sp_ver") or "2.3.3" | ||
| load(pathJoin("sp", sp_ver)) | ||
|
|
||
| w3emc_ver=os.getenv("w3emc_ver") or "2.9.2" | ||
| load(pathJoin("w3emc", w3emc_ver)) | ||
|
|
||
| gftl_shared_ver=os.getenv("gftl_shared_ver") or "v1.5.0" | ||
| load(pathJoin("gftl-shared", gftl_shared_ver)) | ||
|
|
||
| mapl_ver=os.getenv("mapl_ver") or "2.22.0-esmf-8.3.0b09" | ||
| load(pathJoin("mapl", mapl_ver)) | ||
|
|
||
| whatis("Description: UFS build environment common libraries") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| help([[ | ||
| loads UFS Model prerequisites for NOAA Parallelworks/Intel | ||
| ]]) | ||
|
|
||
|
|
||
| prepend_path("MODULEPATH", "/contrib/EPIC/spack-stack/spack-stack-1.3.0/envs/unified-dev/install/modulefiles/Core") | ||
|
|
||
| stack_intel_ver=os.getenv("stack_intel_ver") or "2021.3.0" | ||
| load(pathJoin("stack-intel", stack_intel_ver)) | ||
|
|
||
| stack_impi_ver=os.getenv("stack_impi_ver") or "2021.3.0" | ||
| load(pathJoin("stack-intel-oneapi-mpi", stack_impi_ver)) | ||
|
|
||
| cmake_ver=os.getenv("cmake_ver") or "3.23.1" | ||
| load(pathJoin("cmake", cmake_ver)) | ||
|
|
||
| prepend_path("MODULEPATH", "/contrib/spack-stack/modulefiles/core") | ||
| stack_python_ver=os.getenv("stack_python_ver") or "3.9.12" | ||
| load(pathJoin("stack-python", stack_python_ver)) | ||
|
|
||
| load("ufs_common_spack") | ||
|
|
||
| setenv("CC", "mpiicc") | ||
| setenv("CXX", "mpiicpc") | ||
| setenv("FC", "mpiifort") | ||
| setenv("CMAKE_Platform", "noaacloud.intel") | ||
|
|
||
| whatis("Description: UFS build environment") |
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| #!/bin/sh | ||
| #SBATCH -e err | ||
| #SBATCH -o out | ||
| #SBATCH --qos=batch | ||
| #SBATCH --nodes=1 | ||
| #SBATCH --ntasks-per-node=@[TPN] | ||
| #SBATCH --job-name="@[JBNME]" | ||
|
|
||
| set -eux | ||
|
|
||
| echo -n " $( date +%s )," > job_timestamp.txt | ||
| echo "Compile started: " `date` | ||
|
|
||
| @[PATHRT]/compile.sh @[MACHINE_ID] "@[MAKE_OPT]" @[COMPILE_NR] | ||
|
|
||
| echo "Compile ended: " `date` | ||
| echo -n " $( date +%s )," >> job_timestamp.txt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| #!/bin/sh | ||
| #SBATCH -e err | ||
| #SBATCH -o out | ||
| #SBATCH --qos=batch | ||
| ### #SBATCH --ntasks=@[TASKS] | ||
| #SBATCH --nodes=@[NODES] | ||
| #SBATCH --ntasks-per-node=@[TPN] | ||
| #SBATCH --job-name="@[JBNME]" | ||
| #SBATCH --exclusive | ||
|
|
||
| set -eux | ||
| echo -n " $( date +%s )," > job_timestamp.txt | ||
|
|
||
| set +x | ||
| MACHINE_ID=noaacloud | ||
| module use $( pwd -P ) | ||
| module use /contrib/EPIC/spack-stack/spack-stack-1.3.0/envs/unified-dev/install/modulefiles/Core | ||
| module load stack-intel/2021.3.0 stack-intel-oneapi-mpi/2021.3.0 | ||
| module load ufs-weather-model-env/unified-dev | ||
| module list | ||
|
|
||
| set -x | ||
|
|
||
| ulimit -s unlimited | ||
| ulimit -l unlimited | ||
|
|
||
| echo "Model started: " `date` | ||
|
|
||
| #export MPI_TYPE_DEPTH=20 | ||
| export OMP_STACKSIZE=512M | ||
| export KMP_AFFINITY=scatter | ||
| export OMP_NUM_THREADS=1 | ||
| #export ESMF_RUNTIME_COMPLIANCECHECK=OFF:depth=4 | ||
| #export PSM_RANKS_PER_CONTEXT=4 | ||
| #export PSM_SHAREDCONTEXTS=1 | ||
| #export ESMF_RUNTIME_PROFILE=ON | ||
| #export ESMF_RUNTIME_PROFILE_OUTPUT="SUMMARY" | ||
|
|
||
| # Avoid job errors because of filesystem synchronization delays | ||
| sync && sleep 1 | ||
|
|
||
| srun --mpi=pmi2 --label -n @[TASKS] ./fv3.exe | ||
|
|
||
| echo "Model ended: " `date` | ||
| echo -n " $( date +%s )," >> job_timestamp.txt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is hacky and terrible. Why are testing scripts trying to automatically determine what machine they are being run on instead of just being specified on the command line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment should probably have gone under "detect_machine.sh", but it still stands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this has been around for as long as I've been involved with the GFS. I suppose that it's handy for the end user -- one less thing to specify when running tests.