Skip to content

Jet build config updates (contains #53 update the descriptions of the GSD_SAR_v1 and RRFS_v0 tests)#55

Merged
climbfuji merged 8 commits into
NCAR:dtc/developfrom
climbfuji:linlin_update_sar_rrfs_tests
Jun 16, 2020
Merged

Jet build config updates (contains #53 update the descriptions of the GSD_SAR_v1 and RRFS_v0 tests)#55
climbfuji merged 8 commits into
NCAR:dtc/developfrom
climbfuji:linlin_update_sar_rrfs_tests

Conversation

@climbfuji
Copy link
Copy Markdown

@climbfuji climbfuji commented Jun 15, 2020

This PR:

Associated PRs:
NCAR/fv3atm#53
#55

For regression testing information, see below.

@climbfuji climbfuji marked this pull request as ready for review June 15, 2020 20:44
@climbfuji
Copy link
Copy Markdown
Author

Regression testing on hera.intel against official EMC baseline using rt.conf: all tests pass

rt_full_hera_intel.log

@climbfuji
Copy link
Copy Markdown
Author

climbfuji commented Jun 15, 2020

Regression testing on hera.intel against existing baseline created from head of dtc/develop, using rt_ccpp_gsd.conf: the following two tests fail (as expected because of the changes to the suite definition files), all others pass:

fv3_ccpp_rrfs_v0
fv3_ccpp_gsd_sar_v1

rt_ccpp_gsd_hera_intel_verify_against_existing_baseline.log
rt_ccpp_gsd_hera_intel_verify_against_existing_baseline_fail_test.log

@climbfuji
Copy link
Copy Markdown
Author

Manual testing on Jet: compiling the executable with CMake and CCPP turned on now uses the correct multi-SIMD instructions sets.

@climbfuji
Copy link
Copy Markdown
Author

@JeffBeck-NOAA for your information - jet build system updates and @panll's changes to the suites.

@climbfuji
Copy link
Copy Markdown
Author

Regression testing on hera.intel using rt_ccpp_gsd.conf: first create new baseline, then verify against it: all tests pass.

rt_ccpp_gsd_hera_intel_create_new_baseline.log
rt_ccpp_gsd_hera_intel_verify_new_baseline.log

@climbfuji
Copy link
Copy Markdown
Author

This PR is ready to merge. @panll @llpcarson @grantfirl whoever has time please review. Thanks!

Copy link
Copy Markdown

@panll panll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@climbfuji climbfuji merged commit 43ce0c4 into NCAR:dtc/develop Jun 16, 2020
@climbfuji
Copy link
Copy Markdown
Author

@JeffBeck-NOAA FYI the jet update is merged into ufs-weather-model. Can you want to test this with your updated build_forecast.sh script, please?

@JeffBeck-NOAA
Copy link
Copy Markdown

@climbfuji I can confirm that these changes (along with the build_forecast.sh script mods) now work on Jet. I was able to successfully run a test using xJet. Thank you for your help with this fix!

SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/ufs-weather-model that referenced this pull request Feb 1, 2021
…CAR#55)

Code is identical to original/current code in the authoritative repository (NOAA-PSD, branch master)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants