Skip to content

dtc/hwrf-physics: combined version of HAFS/GFS moninedmf scheme (hybrid EDMF PBL)#35

Merged
climbfuji merged 9 commits into
NCAR:dtc/hwrf-physicsfrom
climbfuji:dtc-hwrf-physics-add-moninedmf
Apr 7, 2020
Merged

dtc/hwrf-physics: combined version of HAFS/GFS moninedmf scheme (hybrid EDMF PBL)#35
climbfuji merged 9 commits into
NCAR:dtc/hwrf-physicsfrom
climbfuji:dtc-hwrf-physics-add-moninedmf

Conversation

@climbfuji
Copy link
Copy Markdown

@climbfuji climbfuji commented Apr 6, 2020

    git cherry-pick e6fe22ffde6425800b7ed2e1cf3748b606806d28
    git cherry-pick a99d5e73f94f5ffb3bd9bbb1a3dc04171026b6d7
    git cherry-pick 5570528f22a9815437e0ef5b413435a8b9fd5881
    git cherry-pick 2bb15be8cc15c69c178b6e443c0ab8c0d75ef318
  • added HWRF physics tests to tests/rt.conf for CCPP PROD and REPRO
  • added README_HWRF_PHYSICS.txt
  • correct regression test baseline (control) directories for tests fv3_ccpp_regional_c768_FA_update_moist and fv3_ccpp_regional_c768_HWRF_PBL

Associated PRs:

NCAR/ccpp-physics#428
NCAR/fv3atm#37
#35

For regression testing information, see below.

@climbfuji
Copy link
Copy Markdown
Author

@grantfirl @mzhangw @grantfirl please make sure that I cherry-picked all the relevant commits and didn't miss anything hidden in the "update to dtc/develop" commits (which I did not cherry-pick). I am running the full regression tests on hera.intel now. Thanks!

@grantfirl
Copy link
Copy Markdown
Collaborator

The cherry-picked commits are correct.

@climbfuji
Copy link
Copy Markdown
Author

During the first round of regression tests on hera.intel, several failed because of file system issues or actual bugs in the regression test setup:

$ cat fail_test
fv3_restart
fv3_read_inc
fv3_wrtGauss_nemsio_c768
fv3_ccpp_wrtGauss_nemsio_c768
fv3_ccpp_regional_c768_HWRF_PBL
fv3_ccpp_regional_c768_FA_update_moist
fv3_ccpp_regional_c768_FA_update_moist
fv3_ccpp_regional_c768_HWRF_PBL

rt_full_step1.log

After fixing the errors in the newly added regression tests, I reran all those that failed above. The two newly added tests (both in REPRO and PROD mode) now fail correctly because of missing baselines (but they run to completion).

$ cat fail_test
fv3_ccpp_regional_c768_FA_update_moist
fv3_ccpp_regional_c768_HWRF_PBL
fv3_ccpp_regional_c768_FA_update_moist
fv3_ccpp_regional_c768_HWRF_PBL

rt_rerun_step2.log

@climbfuji climbfuji merged commit 228dda8 into NCAR:dtc/hwrf-physics Apr 7, 2020
@climbfuji climbfuji mentioned this pull request Apr 7, 2020
SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/ufs-weather-model that referenced this pull request Sep 24, 2020
…elop

Update gsd/develop from NOAA-EMC develop
SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/ufs-weather-model that referenced this pull request Dec 3, 2020
* bring GFS.v16 code changes back to develop branch
* update upp lib in hera module
* use test hpc stack lib
* update upp lib in fv3 for cmake
* update post control files
* update upp lib in hpcstack on hera, orion and dell and in nceplibs on cray
* add change in fv3 dycore NCAR#35
* remove duplicate read_data in fms_mod in external_ic.F90
Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com>
Co-authored-by: Dom Heinzeller <climbfuji@ymail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants