UFS-dev PR#129#122
Merged
Merged
Conversation
* Convective reflectivity added for NSSL,Thompson mp,SAS,GF shal/deep * Bug fix: htop intent set to in, modified if condition for convective refl. * if do_deep is false, set deep and shal parameters to -1. This will prevent conv refl from being computed. * Revert imfhsalcnv and imfdeepcnv changes * Bug fix for conv refl,remove conv refl computation from the cu_gf driver * change imfshallow and imfdeep to -1 since no convection is used, otherwise it will try to compute convective reflectivity * Replace 273.16 with already defined physical constant, con_t0c
Collaborator
Author
|
RTs expected to fail: hafs_regional_atm_thompson_gfdlsf_intel |
Collaborator
Author
|
@mkavulich This is ready for your review. We're not running RTs per the discussion since they were run in ufs-community#1996 |
mkavulich
reviewed
Mar 11, 2024
Collaborator
mkavulich
left a comment
mkavulich
left a comment
There was a problem hiding this comment.
Looks good once submodules are updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identical to ufs-community#1996