Add Global Dimension Variables for IODA v3 Compliance #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-p-w
reviewed
Jun 2, 2025
jim-p-w
approved these changes
Jun 2, 2025
liujake
approved these changes
Jun 5, 2025
Collaborator
liujake
left a comment
liujake
left a comment
There was a problem hiding this comment.
I am merging to accelerate this.
amstokely
added a commit
that referenced
this pull request
Jun 13, 2025
This PR updates the write_iodav3_netcdf subroutine to write explicit global variables for each dimension in the output NetCDF file. This change ensures compatibility with the IODA v3 format, which requires dimension variables to be present at the global level. Update README with GOES-ABI Converter Installation and Usage Instructions (#83) Summary: This PR updates the README.md to document how to install and use the GOES-ABI converter included in obs2ioda. It also improves the instructions for running the validation test suite. Changes: Added instructions for enabling the GOES-ABI converter during the CMake configuration step (-DBUILD_GOES_ABI_CONVERTER=ON). Added a section explaining how to run the GOES-ABI converter from the command line. Expanded the test instructions to show how to run specific test suites using pytest -m, including the goes_abi marker. Changed name of datetime variable to dateTime and fixed bug that occurred when writing dateTime with superobs enabled in goes_abi. Defined linker language for fortran test targets. Changed netcdf4 to netCDF4 in README instructions. Fixed how Channel variable is set in goes_abi converter. Also added a function for creating fortran ctest tests. Added units attribute for dateTime variable. Updated test reference files. Updated goes_abi ouput file naming. Added docstring for set_goes_abi_out_fname subroutine. Added a conda env recipe yaml for creating the obs2ioda python testing env. Also updated the README. Created csh derecho environment scripts along with a bash intel derecho env script.
amstokely
added a commit
that referenced
this pull request
Jun 13, 2025
This PR updates the write_iodav3_netcdf subroutine to write explicit global variables for each dimension in the output NetCDF file. This change ensures compatibility with the IODA v3 format, which requires dimension variables to be present at the global level. Update README with GOES-ABI Converter Installation and Usage Instructions (#83) Summary: This PR updates the README.md to document how to install and use the GOES-ABI converter included in obs2ioda. It also improves the instructions for running the validation test suite. Changes: Added instructions for enabling the GOES-ABI converter during the CMake configuration step (-DBUILD_GOES_ABI_CONVERTER=ON). Added a section explaining how to run the GOES-ABI converter from the command line. Expanded the test instructions to show how to run specific test suites using pytest -m, including the goes_abi marker. Changed name of datetime variable to dateTime and fixed bug that occurred when writing dateTime with superobs enabled in goes_abi. Defined linker language for fortran test targets. Changed netcdf4 to netCDF4 in README instructions. Fixed how Channel variable is set in goes_abi converter. Also added a function for creating fortran ctest tests. Added units attribute for dateTime variable. Updated test reference files. Updated goes_abi ouput file naming. Added docstring for set_goes_abi_out_fname subroutine. Added a conda env recipe yaml for creating the obs2ioda python testing env. Also updated the README. Created csh derecho environment scripts along with a bash intel derecho env script.
amstokely
added a commit
that referenced
this pull request
Jun 13, 2025
…ll behavior and simplify environment setup (#86) * Added global variables for each dimension. (#82) This PR updates the write_iodav3_netcdf subroutine to write explicit global variables for each dimension in the output NetCDF file. This change ensures compatibility with the IODA v3 format, which requires dimension variables to be present at the global level. Update README with GOES-ABI Converter Installation and Usage Instructions (#83) Summary: This PR updates the README.md to document how to install and use the GOES-ABI converter included in obs2ioda. It also improves the instructions for running the validation test suite. Changes: Added instructions for enabling the GOES-ABI converter during the CMake configuration step (-DBUILD_GOES_ABI_CONVERTER=ON). Added a section explaining how to run the GOES-ABI converter from the command line. Expanded the test instructions to show how to run specific test suites using pytest -m, including the goes_abi marker. Changed name of datetime variable to dateTime and fixed bug that occurred when writing dateTime with superobs enabled in goes_abi. Defined linker language for fortran test targets. Changed netcdf4 to netCDF4 in README instructions. Fixed how Channel variable is set in goes_abi converter. Also added a function for creating fortran ctest tests. Added units attribute for dateTime variable. Updated test reference files. Updated goes_abi ouput file naming. Added docstring for set_goes_abi_out_fname subroutine. Added a conda env recipe yaml for creating the obs2ioda python testing env. Also updated the README. Created csh derecho environment scripts along with a bash intel derecho env script. * Deleted leftover commit tag from rebase in README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the write_iodav3_netcdf subroutine to write explicit global variables for each dimension in the output NetCDF file. This change ensures compatibility with the IODA v3 format, which requires dimension variables to be present at the global level.