Skip to content

Modify noahmpdrv for global distributed urban parameters#96

Merged
cenlinhe merged 1 commit intoNCAR:release-v4.6-WRFfrom
epn09:dist-params
Jan 16, 2024
Merged

Modify noahmpdrv for global distributed urban parameters#96
cenlinhe merged 1 commit intoNCAR:release-v4.6-WRFfrom
epn09:dist-params

Conversation

@epn09
Copy link

@epn09 epn09 commented Jun 15, 2023

Add global distributed urban parameters to the driver.

@cenlinhe
Copy link
Collaborator

I will come back to this PR later for more detailed review

@cenlinhe cenlinhe requested review from cenlinhe and tslin2 June 15, 2023 15:12
@cenlinhe cenlinhe requested review from CharlesZheZhang and removed request for cenlinhe and tslin2 October 26, 2023 03:14
@tslin2
Copy link
Collaborator

tslin2 commented Oct 26, 2023

It read three parameters which looks okay to me.

@cenlinhe cenlinhe changed the base branch from noahmp_v4.5_develop to release-v4.6-WRF January 16, 2024 16:42
@cenlinhe cenlinhe requested review from CharlesZheZhang, cenlinhe and tslin2 and removed request for CharlesZheZhang January 16, 2024 16:50
@cenlinhe
Copy link
Collaborator

cenlinhe commented Jan 16, 2024

This PR is for WRFv4.6 urban updates: wrf-model/WRF#1881
For Noah-MP v5 updates with this, I will do it later in a similar but more elegant way after coupling WRF with Noah-MP v5

Copy link
Collaborator

@CharlesZheZhang CharlesZheZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me

Copy link
Collaborator

@cenlinhe cenlinhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes (adding 3 new variables as urban inputs) look good to me.

Copy link
Collaborator

@tslin2 tslin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code add three variables into SLUCM model,

lf_urb2d_s
z0_urb2d
vegfra

The changes look okay here, but it may require further test in coupling with WRF

@cenlinhe
Copy link
Collaborator

This update will currently not work with HRLDAS/Noah-MP-urban coupling, since we have not included these new inputs for the HRLDAS/Noah-MP-urban interface for the non-refactored code. We will do this for the version 5 in the near future along with the coupling of Noah-MP v5 with WRF.

@cenlinhe cenlinhe merged commit 848f54a into NCAR:release-v4.6-WRF Jan 16, 2024
@epn09 epn09 deleted the dist-params branch January 17, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants