Skip to content

Sync with develop branch update for glacier bug fix #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cenlinhe merged 2 commits into from
Mar 31, 2022
Merged

Sync with develop branch update for glacier bug fix #43

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
babe6c0
bug fix for snow albedo with cosz<0 in glacier code
cenlinhe Mar 23, 2022
34b0b67
add more comments on cosz<0 for glacier bug fix
cenlinhe Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions src/module_sf_noahmp_glacier.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,18 +708,23 @@ SUBROUTINE RADIATION_GLACIER (DT ,TG ,SNEQVO ,SNEQV ,COSZ , & !i
ALBICE(1) = 0.80 !albedo land ice: 1=vis, 2=nir
ALBICE(2) = 0.55

! snow age
! compute snow albedo only if cosz >0
! to be consistent with the main NoahMP code, currently do not include snow aging when sun is not present
! this needs more future work
if (COSZ > 0.0) then

CALL SNOW_AGE_GLACIER (DT,TG,SNEQVO,SNEQV,TAUSS,FAGE)
! snow age

! snow albedos: age even when sun is not present
CALL SNOW_AGE_GLACIER (DT,TG,SNEQVO,SNEQV,TAUSS,FAGE)

IF(OPT_ALB == 1) &
CALL SNOWALB_BATS_GLACIER (NBAND,COSZ,FAGE,ALBSND,ALBSNI)
IF(OPT_ALB == 2) THEN
CALL SNOWALB_CLASS_GLACIER(NBAND,QSNOW,DT,ALB,ALBOLD,ALBSND,ALBSNI)
ALBOLD = ALB
END IF
IF(OPT_ALB == 1) &
CALL SNOWALB_BATS_GLACIER (NBAND,COSZ,FAGE,ALBSND,ALBSNI)
IF(OPT_ALB == 2) THEN
CALL SNOWALB_CLASS_GLACIER(NBAND,QSNOW,DT,ALB,ALBOLD,ALBSND,ALBSNI)
ALBOLD = ALB
END IF

endif

! zero summed solar fluxes

Expand Down