Fix nonstandard unary operator uses: *-#30
Merged
cenlinhe merged 1 commit intoNCAR:developfrom Jan 28, 2022
Merged
Conversation
These were found with testing for the NCAR derecho machine by Davide Del Vento. Any `a * -b` should be recast as `a * (-b)`. modified: module_sf_noahmplsm.F
Contributor
Author
|
@cenlinhe @davidedelvento @weiwangncar |
Collaborator
|
@davegill Thanks. Looks good to me. By the way, what do you mean by "2-way feedback "? |
Contributor
Author
NoahMP gives code the WRF, and WRF helps with bugfixes to NoahMP: a mutually beneficial, two-way interaction. |
Collaborator
|
@davegill you are right! This is an excellent demonstration! |
davegill
added a commit
to davegill/WRF
that referenced
this pull request
Jan 28, 2022
TYPE: bug fix KEYWORDS: unary operator, NoahMP SOURCE: Davide del Vento (CISL/NCAR), internal DESCRIPTION OF CHANGES: Problem: Several occurences of `a * -b` were caught by the Cray compiler during routine pre-derecho testing of WRF. Solution: The standard requires parentheses: `a * (-b)`. How to fix the NoahMP version: 1. Get the WRF source code, and the right branch (let's assume `develop` is the WRF branch). ``` git clone https://github.com/wrf-model/WRF cd WRF git checkout develop git checkout -b new_noahmp_for_some_reason ``` 2. Get the NoahMP repo available and in the WRF source code. Must be in the top level of the WRF directory structure to issue this command. ``` git submodule update --init --recursive ``` 3. Get the correct NoahM branch. Usually the NoahMP group tells us what to pick up. Here, let us assume it is the `release-v4.4-WRF` branch from NoahMP. ``` cd phys/noahmp git checkout release-v4.4-WRF cd .. ``` 4. Stage this modification. ``` git add noahmp ``` ISSUE: Fixes wrf-model#1659 ASSOCIATED REPOSITORY CHANGE: NCAR/noahmp#30 LIST OF MODIFIED FILES: modified: phys/noahmp TESTS CONDUCTED: 1. All non-standard syntax of above form was modified. 2. All jenkins tests are PASS.
davegill
added a commit
to wrf-model/WRF
that referenced
this pull request
Jan 28, 2022
TYPE: bug fix KEYWORDS: unary operator, NoahMP SOURCE: Davide Del Vento (CISL/NCAR), internal DESCRIPTION OF CHANGES: Problem: Several occurrences of `a * -b` were caught by the Cray compiler during routine pre-derecho testing of WRF. Solution: The standard requires parentheses: `a * (-b)`. ### How to get a different (probably new) NoahMP version in the WRF repository 1. Get the WRF source code, and the right branch (let's assume `develop` is the WRF branch). ``` git clone https://github.com/wrf-model/WRF cd WRF git checkout develop git checkout -b new_noahmp_for_some_reason ``` 2. Get the NoahMP repo available and in the WRF source code. You must be in the top-most level of the WRF directory structure to issue this command on some OS. ``` git submodule update --init --recursive ``` 3. Get the correct NoahMP branch. Usually the NoahMP group tells us what to pick up. Here, let us assume it is the `release-v4.4-WRF` branch from NoahMP. ``` cd phys/noahmp git checkout release-v4.4-WRF cd .. ``` 4. Stage this modification. ``` git add noahmp ``` ISSUE: Fixes #1659 ASSOCIATED REPOSITORY CHANGE: NCAR/noahmp#30 LIST OF MODIFIED FILES: modified: phys/noahmp TESTS CONDUCTED: 1. All non-standard syntax of above form was modified. 2. All jenkins tests are PASS.
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
…l#1660) TYPE: bug fix KEYWORDS: unary operator, NoahMP SOURCE: Davide Del Vento (CISL/NCAR), internal DESCRIPTION OF CHANGES: Problem: Several occurrences of `a * -b` were caught by the Cray compiler during routine pre-derecho testing of WRF. Solution: The standard requires parentheses: `a * (-b)`. ### How to get a different (probably new) NoahMP version in the WRF repository 1. Get the WRF source code, and the right branch (let's assume `develop` is the WRF branch). ``` git clone https://github.com/wrf-model/WRF cd WRF git checkout develop git checkout -b new_noahmp_for_some_reason ``` 2. Get the NoahMP repo available and in the WRF source code. You must be in the top-most level of the WRF directory structure to issue this command on some OS. ``` git submodule update --init --recursive ``` 3. Get the correct NoahMP branch. Usually the NoahMP group tells us what to pick up. Here, let us assume it is the `release-v4.4-WRF` branch from NoahMP. ``` cd phys/noahmp git checkout release-v4.4-WRF cd .. ``` 4. Stage this modification. ``` git add noahmp ``` ISSUE: Fixes wrf-model#1659 ASSOCIATED REPOSITORY CHANGE: NCAR/noahmp#30 LIST OF MODIFIED FILES: modified: phys/noahmp TESTS CONDUCTED: 1. All non-standard syntax of above form was modified. 2. All jenkins tests are PASS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were found with testing for the NCAR derecho machine by
Davide Del Vento for the WRF model. Any
a * -bshould be recast asa * (-b).modified: module_sf_noahmplsm.F