Bug fix for domain size input variable#127
Merged
cenlinhe merged 5 commits intoNCAR:release-v5.0-LISfrom Apr 26, 2024
Merged
Conversation
sync with NCAR/noahmp v5.0-LIS branch
Collaborator
Author
|
@RAbolafiaRosenzweig after your LIS/NoahMP testing, if it is correct, then we can approve this PR. |
tslin2
approved these changes
Apr 23, 2024
Collaborator
tslin2
left a comment
tslin2
left a comment
There was a problem hiding this comment.
this scale awareness issues is found by Ronnie in LIS Noah-MPv5.0 for enhanced SCF scheme. The initial DX is not given correctly in the LIS Noah-MPv5.0.
RAbolafiaRosenzweig
approved these changes
Apr 25, 2024
Collaborator
RAbolafiaRosenzweig
left a comment
RAbolafiaRosenzweig
left a comment
There was a problem hiding this comment.
These changes allow GridSize to be defined in the lis.config file for scale aware parameterizations. Ronnie Abolafia-Rosenzweig tested the update to work correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.