AtmosForcingMod, OptRainSnowPartition == 5 update for warm instances#112
Merged
cenlinhe merged 8 commits intoNCAR:developfrom Feb 2, 2024
Merged
AtmosForcingMod, OptRainSnowPartition == 5 update for warm instances#112cenlinhe merged 8 commits intoNCAR:developfrom
cenlinhe merged 8 commits intoNCAR:developfrom
Conversation
Sync with develop branch for bug fixes
use consistent common undefined value for initialization
Sync with develop branch for bug fix
Updated to avoid numerical errors associated with low FrozenPrecipFrac for OptRainSnowPartition = 5
AtmosForcingMod.F90 updated to avoid numerical errors associated with warm wet bulb temperature for OptRainSnowPartition = 5
Update to OptRainSnowPartition == 5 to avoid numerical errors in instances of warm temperatures by forcing FrozenPrecipFrac = 0
if ( TemperatureWetBulb >= 5) then FrozenPrecipFrac = 0 to avoid crashing in instances of high temperatures for OptRainSnowPartition == 5
FrozenPrecipFrac = 0.0 constraint imposed for instances of TemperatureAirRefHeight > 10C to avoid numerical errors in warm instances for OptRainSnowPartition == 5.
cenlinhe
approved these changes
Feb 2, 2024
Collaborator
cenlinhe
left a comment
cenlinhe
left a comment
There was a problem hiding this comment.
This PR fixes the numerical error for snowfall fraction calculation during wel-bulb temperature scheme when temperature is high. The fix looks good to me.
Collaborator
|
@RAbolafiaRosenzweig next time, you may want to use a more informative commit message/title when you update the code files. Currently, all your commit messages are showing "Add files via upload". Also, next time, you may want to try directly modify the github code on your local machine and then commit the change and submit the change to your forked github online and then create the PR. In this way, you do not need to upload files separately. |
Collaborator
Author
|
Thank you for these notes. I will make sure to have more detailed comments
and consider directly updating github code in future instances.
…-Ronnie
On Fri, Feb 2, 2024 at 9:02 AM Cenlin_He ***@***.***> wrote:
@RAbolafiaRosenzweig <https://github.com/RAbolafiaRosenzweig> next time,
you may want to use a more informative commit message/title when you update
the code files. Currently, all your commit messages are showing "Add files
via upload". Also, next time, you may want to try directly modify the
github code on your local machine and then commit the change and submit the
change to your forked github online and then create the PR. In this way,
you do not need to upload files separately.
—
Reply to this email directly, view it on GitHub
<#112 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIXTHJG7FUGOMIPUQDXHUPLYRUEZJAVCNFSM6AAAAABCW4L5IOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRUGE3DOMRRG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
tslin2
reviewed
Feb 2, 2024
tslin2
approved these changes
Feb 2, 2024
Collaborator
tslin2
left a comment
tslin2
left a comment
There was a problem hiding this comment.
looks good to me! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to set FrozenPrecipFrac = 0.0 for instances of TemperatureAirRefHeight>=10C to avoid numerical errors in rain/snowfall partitioning calculation for warm instances when OptRainSnowPartition == 5.