Skip to content

negative theta in pedo transfer function #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cenlinhe merged 5 commits into from
Jan 18, 2024
Merged

negative theta in pedo transfer function #111

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e9b85a0
merge
tslin2 Jan 18, 2024
074a66e
negative theta_1500 in PedoTransferSR2006Mod.F90
tslin2 Jan 18, 2024
53767f4
update
tslin2 Jan 18, 2024
75cd9a4
update theta
tslin2 Jan 18, 2024
2ba002a
update for value
tslin2 Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions drivers/hrldas/PedoTransferSR2006Mod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,9 @@ subroutine PedoTransferSR2006(NoahmpIO, noahmp, Sand, Clay, Orgm)
+ sr2006_psi_e_b*psi_et &
+ sr2006_psi_e_c

theta_33 = max(10.0**-3.0,theta_33) ! For numerical stability
theta_1500 = max(10.0**-5.0,theta_1500) ! For numerical stability
Copy link
Collaborator

@cenlinhe cenlinhe Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may cause another issue that log(theta_33) - log(theta_1500) = 0 and then bexp = xx/ 0, leading to floating issue. maybe set different min values for theta_33 and theta_1500 with theta_1500 having a smaller min value to ensure log(theta_33) - log(theta_1500) > 0.

Copy link
Collaborator Author

@tslin2 tslin2 Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. I have updated. Thanks

Copy link
Collaborator

@cenlinhe cenlinhe Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the typical range of theta_33? Would 1e-3 be too large for the min value of theta_33? Similarly for theta_1500. For example, do we need to make their min values smaller, e.g., min(theta_33) = 1e-5, and min(theta_1500) = 1e-6?

Copy link
Collaborator Author

@tslin2 tslin2 Jan 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theta_1500 is the wilting point, and theta_33 is the field capacity.

The general range for the wilting point is 0.01-0.3, and for field capacity, it is 0.05-0.4

1e-5 is very small, with almost no soil moisture condition. If think about the table value for different soil types, the minimum value has 0.006 wilting point and 0.10 field capacity, except for water.

Also, there is another constraint at the end of this code, that use 0.17 and 0.01 for field capacity and wilting point, respectively.

noahmp/drivers/hrldas/PedoTransferSR2006Mod.F90

Line 187 in 1a853a5

smcref = max(0.17 ,min(smcref, smcmax))

noahmp/drivers/hrldas/PedoTransferSR2006Mod.F90

Line 188 in 1a853a5

smcwlt = max(0.01 ,min(smcwlt, smcref))

Copy link
Collaborator

@cenlinhe cenlinhe Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification. This makes sense to me. Your current values look good then.


! assign property values
smcwlt = theta_1500
smcref = theta_33
Expand Down