modify full_ic_frq mod for gfortran compiler and start j loop from 1 …#128
Merged
cenlinhe merged 1 commit intoNCAR:developfrom Nov 14, 2023
Merged
modify full_ic_frq mod for gfortran compiler and start j loop from 1 …#128cenlinhe merged 1 commit intoNCAR:developfrom
cenlinhe merged 1 commit intoNCAR:developfrom
Conversation
…in reading netcdf variables
cenlinhe
approved these changes
Nov 14, 2023
Collaborator
cenlinhe
left a comment
cenlinhe
left a comment
There was a problem hiding this comment.
This bug fix looks good to me.
Collaborator
|
Note that this issue/bug only occurs in gfortran compiler but not intel and pgi, probably because gfortran compiler has a stricter rule on this. |
tslin2
approved these changes
Nov 14, 2023
Collaborator
tslin2
left a comment
tslin2
left a comment
There was a problem hiding this comment.
These changes look good.
Collaborator
|
@tslin2 from my end, it seems that you have not approved this PR, so that I cannot merge it. Could you please check? |
tslin2
reviewed
Nov 14, 2023
Collaborator
tslin2
left a comment
tslin2
left a comment
There was a problem hiding this comment.
I approve these changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…in reading netcdf variables
This commit is to avoid full_ic_frq == 0 in mod function used in gfortran compiler.
https://github.com/CharlesZheZhang/hrldas/blob/789b8c21c9f2f0a1811dd43ee4677a43453817f5/hrldas/HRLDAS_forcing/create_forcing.F#L445
Also change j loop from 1 in reading netcdf variables.
https://github.com/CharlesZheZhang/hrldas/blob/789b8c21c9f2f0a1811dd43ee4677a43453817f5/hrldas/HRLDAS_forcing/create_forcing.F#L2119