Accumulated cleanup#67
Merged
Merged
Conversation
…/fv3atm into accumulated_cleanup
grantfirl
reviewed
Oct 3, 2022
grantfirl
reviewed
Oct 3, 2022
grantfirl
reviewed
Oct 3, 2022
grantfirl
reviewed
Oct 3, 2022
grantfirl
reviewed
Oct 3, 2022
grantfirl
reviewed
Oct 3, 2022
grantfirl
reviewed
Oct 3, 2022
grantfirl
requested changes
Oct 4, 2022
Collaborator
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
There are several little things in the metadata that would be good to change in order to be consistent with the standard naming rules.
Member
Author
|
@grantfirl I addressed your concerns wrt standard_names. |
added 6 commits
November 2, 2022 08:54
grantfirl
approved these changes
Feb 8, 2023
dustinswales
pushed a commit
to dustinswales/fv3atm
that referenced
this pull request
Feb 8, 2023
Accumulated cleanup
dustinswales
pushed a commit
to dustinswales/fv3atm
that referenced
this pull request
Mar 3, 2023
* Merge pull request NCAR#67 from dustinswales/accumulated_cleanup: ccpp physocs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR contains new interstitial variables in GFS_typedefs to accommodate changes in the underlying physics. These changes are mostly related to the removal of a radiation configuration(data) module, physparam.f. Runtime information is set in GFS_typedefs and provided through the ccpp infrastructure, instead of referencing physparam.f throughout the physics.
Issue(s) addressed
Detailed in NCAR #956
Testing
Tested on Cheyenne and Hera with Intel.
Updates need for the RRTMGP RTs (see conversation in NCAR/ccpp-physics#956)