HWRF RRTMG#33
Conversation
mzhangw
requested review from
climbfuji,
grantfirl and
llpcarson
as code owners
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Again, no need for you to make changes, but: you changed the metadata (dimensions) for the Interstitial%clouds array in ccpp-physics, however you didn't make the corresponding change in GFS_typedefs.meta. I will need to correct this when I merge and test your PRs.
| ! ExtDiag(idx)%data(nb)%var3 => Tbd(nb)%phy_f3d(:,:,Model%nseffr) | ||
| ! enddo | ||
| !endif | ||
| if (Model%imp_physics == Model%imp_physics_fer_hires) then |
There was a problem hiding this comment.
Is this output really required for merging? I assume it's ok for your testing, but we don't really need to have these three additional 3-dim arrays in the standard output, or? On the other hand, users can always control this via the diag_table file, in which case it would make sense to re-enable end extend the original if statement?
if (Model%imp_physics == Model%imp_physics_thompson .or. Model%imp_physics == Model%imp_physics_fer_hires) then
There was a problem hiding this comment.
You are correct. It is for my testing purpose.
| [iovr_sw] | ||
| standard_name = flag_for_max_random_overlap_clouds_for_shortwave_radiation | ||
| long_name = sw: max-random overlap clouds | ||
| standard_name = flag_for_cloud_overlapping_method_for_shortwave_radiation |
There was a problem hiding this comment.
@grantfirl please help me reviewing the suggested standard names - you are the expert. Thanks!
dtc/hwrf-physics: HWRF RRTMG (based on #33)
|
This PR was merged into dtc/hwrf-physics, see #38. It will be merged into master when dtc/hwrf-physics is merged into master. |
Cleanup of radiation (clouds) - microphysics interaction
2 participants
this is for HWRF RRTMG