fix array dimensions for phii, prsi in ugwp_driver_v0.F#16
Conversation
|
Darn, just noticed that I messed this up. Will fix and force push. |
grantfirl
force-pushed
the
fix_cires_ugwp_dimension_bug
branch
from
4c82b3b to
aa99bea
Compare
|
This PR has been pulled into #15 |
@climbfuji Did you pull it in after I force-pushed a couple minutes ago? I forgot to delete the old var declaration in my original commit. |
|
I removed the old version and pulled in the new version just now. |
…ue in CCPP version)
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
O yes, I noticed this inconsistency. It doesn't hurt, though, because Fortran will look for two entries at the starting address of the variable Model%cdmbgwd, and find them there (i.e. it just ignores items 3,4). I will pull this into #15 as well. Please no more updates to this PR from now on!
I agree. If Valery has any more of these, should I just put them in a different PR? I'm guessing that these should probably be going through EMC instead of us, though, since they're not really CCPP-related, but it is easy enough for us to do. Ideally, I think that the developer should be making these changes and pushing them to us rather than emailing us bugfixes in the future. |
* add new suite definition files for GFSv15p2, GFSv16beta * update existing suite definition files because of the interstitial code rearrangement (NCAR/ccpp-physics#372) * clean up CCPP compiler flags, add -Wall for GNU in DEBUG mode * add satmedmfvifq, shalcnv, sascnvn, Ferrier-Aligo microphysics and dependencies to CCPP prebuild config * bug fixes for ugwp and noahmp * move previous-timestep precipitation variables from Tbd to Sfcprop (as recommended by @HelinWei-NOAA, see NCAR/ccpp-physics#319) * fix compiler warnings about non-existent include directories * cleanup of old comments in GFS_physics_driver.F90 (see NCAR#4, NCAR#16, and NCAR/ccpp-physics#319 * CCPP annotations in GFS_driver.F90, GFS_radiation_driver.F90, GFS_physics_driver.F90 (comments that describe where code blocks ended up in the CCPP interstitial code) * capability to coldstart FV3 with GSD physics from RAP/HRRR initial conditions (required for FV3 SAR) * new suite definition file for coupled model
…st_code Update to MYNN Surface Layer Scheme and related modules (NCAR#14 - based on latest code)
* add fh00 post control file, add restart output at specified forecast hours, ugwd bug fixes * update module files to use g2tmpl v1.6.0 and post v8.0.1 * add fh00 post control file in fv3.input for inline post * update in runduration in atmos * update RT baseline directory on hera and wcoss * comment out fv3_wrtGauss_nemsio_c768 on dell * update grib2 table for g2tmpl 1.6.0 * update post * comment out print line in FV3
* Update InputsOutputs.rst, Codeoverview * Stampede update (NCAR#15) * Fix build env setup in Chapter 3 (NCAR#16) * cleanup and reorg of 2.2 Directory Structure Co-authored-by: BinLi-NOAA <bin.li@noaa.gov> Co-authored-by: jiandewang <jiande.wang@noaa.gov> Co-authored-by: Ali.Abdolali <37336972+aliabdolali@users.noreply.github.com> Co-authored-by: Ali Abdolali <ali.abdolali@noaa.gov> Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> Co-authored-by: Minsuk Ji <57227195+MinsukJi-NOAA@users.noreply.github.com>
The following changes are from @RongqianYang-NOAA, @barlage, and @wramstrom, to address NoahMP LSM and sea-ice related moving-nesting issues. - Add snow layer and snow soil layer thickness to GFS_type. - Add checks for soil moisture for Noah MP. - Changes for distinguishing between new and old points for snow-related fields reset in moving nest physics. - Add leading_edge logical array to indicate which nest points have been interpolated. Needed for NOAH MP moving nest upgrades. - NOAHMP moving nest sea ice and cryosphere fixes and added variables tiice, tisfc, sncovr, fice, hice. Notes: Lots of contribution (discussions/diagnostics/debugging/testing) from @ChuankaiWang-NOAA, @yonghuiweng, ZhanZhang-NOAA, @helin.wei@noaa.gov, @fanglin.yang@noaa.gov, @BinLiu-NOAA as well.
2 participants
This is an emergency bugfix found by Valery Yudin, communicated through email to @grantfirl.
Associated PR:
NCAR/ccpp-physics#368