UFS-dev PR#309#631
Merged
Merged
Conversation
grantfirl
requested review from
dustinswales,
hertneky,
mkavulich and
scrasmussen
as code owners
Collaborator
Author
|
@scrasmussen @hertneky RT system correctly downloaded and compared against the BL from the most recent main push. The comparisons show NO differences, which is expected for this PR. It looks like everything worked OK. |
scrasmussen
reviewed
Nov 7, 2025
scrasmussen
reviewed
Nov 7, 2025
scrasmussen
approved these changes
Nov 7, 2025
Member
scrasmussen
left a comment
scrasmussen
left a comment
There was a problem hiding this comment.
There are the two whitespace additions that I wouldn't mind being cleaned up but I'll leave it to you, its a small thing. Everything else looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SOURCE: @grantfirl
DESCRIPTION OF CHANGES:
ISSUE: None
ASSOCIATED PRs:
NCAR/ccpp-physics#1169
TESTS CONDUCTED: SCM RTs
This PR catches the NCAR:main branch up with changes from the ufs-community:ufs/dev branch.
Associated ufs/dev PR:
Associated ufsatm PR:
Associated NCAR PR:
REGRESSION TEST CHANGES: None