ufs-dev PR301#617
Merged
Merged
Conversation
grantfirl
approved these changes
Sep 23, 2025
Collaborator
grantfirl
left a comment
There was a problem hiding this comment.
Looks good. I thought that it may have been necessary to add the SCM as a "dycore", but it wouldn't do much good at this point, I don't think, since some UFS physics that the SCM calls still need FV3-specific grid info, even if the SCM "fakes" it (e.g. tile number, etc.). If we need to do something different for the SCM in the future, we can do so at that time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR catches the NCAR:main branch up with changes from the ufs-community:ufs/dev branch PR301.
Associated ufs/dev PR:
Associated fv3atm PR:
Associated NCAR PR:
REGRESSION TEST CHANGES: NONE