UFS-dev PR#183#529
Merged
Merged
Conversation
…emes; allocate the Interstitial DDT as an array of size n_threads
2 tasks
dustinswales
approved these changes
Oct 22, 2024
…'t want a failing run (even if it is on purpose) because it will get flagged and fail CI
Collaborator
Author
|
@dustinswales @mkavulich @scrasmussen RTs run as expected now. There were a couple of failures related to the original PR -- one was that I failed to compile the new suite(s) in the RT CI workflow and the second was that, for testing purposes, I include the |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes similar to NOAA-EMC/ufsatm#798
Additional changes:
-- downstream changes for the above change
RT notes: This PR doesn't change RT results except for the addition of a new test that exercise the GFS_debug.F90 schemes. Note that the
GFS_abortscheme in GFS_debug.F90 is untested because it causes a run failure (on purpose) and CI flags it as a failure, which we don't necessarily want.