New Standard Names#256
Closed
bluefinweiwei wants to merge 1 commit into
Closed
Conversation
modified: scm/src/GFS_typedefs.meta modified: ccpp/config/ccpp_prebuild_config.py modified: scm/src/GFS_typedefs.meta modified: ccpp/framework (new commits) modified: ccpp/physics (new commits)
bluefinweiwei
requested review from
climbfuji,
grantfirl and
llpcarson
as code owners
Collaborator
|
Added work-in-progress label since new standard names need discussion outside of DTC group. |
Collaborator
|
Closed in favor of #267 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
647 standard names have been changed in the *.meta files under ccpp/physics/physics (see PR at NCAR/ccpp-physics#637). Tested using CCPP-SCM and had b4b results for all supported physics suites (v15b2, v16, GSDv1, and RRFSv1beta) except csawmg (need to debug). I didn't commit static_api files but they were always shown as part of the commits. Sorry about that.