Skip to content

Update for Mike Iacono's RRTMG cloud overlap code#192

Merged
grantfirl merged 4 commits into
NCAR:masterfrom
grantfirl:rrtmg-cloud-overlap-updates_gjf
Oct 1, 2020
Merged

Update for Mike Iacono's RRTMG cloud overlap code#192
grantfirl merged 4 commits into
NCAR:masterfrom
grantfirl:rrtmg-cloud-overlap-updates_gjf

Conversation

@grantfirl
Copy link
Copy Markdown
Collaborator

@grantfirl grantfirl commented Aug 11, 2020

This PR matches NOAA-EMC/ufsatm#157 for the updated cloud overlap for RRTMG from Mike Iacono (AER).

Associated PRs:
NOAA-EMC/ufsatm#157
NCAR/ccpp-physics#487

This effectively replaces #188.

climbfuji
climbfuji reviewed Aug 11, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Will have to wait, though, until we can merge the ccpp-physics PR.

@grantfirl
Copy link
Copy Markdown
Collaborator Author

grantfirl commented Aug 11, 2020

This code has been tested to build/compile/run with NCAR/ccpp-physics#487.

I ran the TWPICE maritime deep convective case using the default cloud overlap namelist parameters and setting both SW and LW overlap methods to 4 and 5. All ran, with very minor differences for this case (see attached plots).
profiles_mean_dT_dt_lwrad.pdf
profiles_mean_dT_dt_swrad.pdf
profiles_mean_T.pdf

This was referenced Aug 11, 2020
Merged
Closed
@grantfirl
Copy link
Copy Markdown
Collaborator Author

grantfirl commented Aug 11, 2020

Looks good to me. Will have to wait, though, until we can merge the ccpp-physics PR.

Yep, will do. I'll update the ccpp-physics submodule pointer when that PR is merged before merging this.

@grantfirl
Copy link
Copy Markdown
Collaborator Author

grantfirl commented Sep 28, 2020

@climbfuji @llpcarson Now that NOAA-EMC/ufsatm#157 is merged, this should be good to go to.

@grantfirl grantfirl requested a review from climbfuji September 28, 2020 15:58
climbfuji
climbfuji approved these changes Oct 1, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks familiar!

@grantfirl grantfirl merged commit 5fc8e1b into NCAR:master Oct 1, 2020
dustinswales pushed a commit to dustinswales/ccpp-scm that referenced this pull request May 16, 2022
@grantfirl
Merge pull request NCAR#192 from grantfirl/rrtmg-cloud-overlap-update…
acd65c5 
…s_gjf

Update for Mike Iacono's RRTMG cloud overlap code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@llpcarson llpcarson Awaiting requested review from llpcarson

1 more reviewer

@climbfuji climbfuji climbfuji approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@grantfirl @climbfuji