Skip to content

added some 2018 LASSO cases#191

Merged
grantfirl merged 3 commits into
NCAR:masterfrom
wangevine:add_lasso_cases
Aug 10, 2020
Merged

added some 2018 LASSO cases#191
grantfirl merged 3 commits into
NCAR:masterfrom
wangevine:add_lasso_cases

Conversation

@wangevine
Copy link
Copy Markdown
Contributor

No description provided.

@grantfirl
Copy link
Copy Markdown
Collaborator

This PR adds 16 new LASSO cases from 2018 to the repository. Changes from @wangevine include:

  1. new case configuration files in scm/etc/case_config (x16)
  2. new case data files in scm/data/processed_case_input (x17)
  3. new unprocessed case data in scm/data/raw_case_input (x16)

@grantfirl added a new multi_run configuration file to run through all new LASSO cases using the default GFS_v15p2 and GFS_v16beta suites.

Copy link
Copy Markdown
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangevine I'm just about ready to pull these changes into the repository. FYI, I added a new file (LASSO_multi_run.py) for convenience of running through these cases. The only file that I see that I'm not sure belongs is scm/data/processed_case_input/LASSO_20180514_testnoforc.nc. Was this used for your own testing? Unless there is a good reason for this to stay in, with your permission, I'd like to remove that file.

@wangevine
Copy link
Copy Markdown
Contributor Author

wangevine commented Aug 10, 2020 via email

@grantfirl
Copy link
Copy Markdown
Collaborator

Yes, that file should be removed. Sorry I missed it. Wayne

On Mon, Aug 10, 2020 at 8:08 PM grantfirl @.> wrote: @.* approved this pull request. @wangevine https://github.com/wangevine I'm just about ready to pull these changes into the repository. FYI, I added a new file (LASSO_multi_run.py) for convenience of running through these cases. The only file that I see that I'm not sure belongs is scm/data/processed_case_input/LASSO_20180514_testnoforc.nc. Was this used for your own testing? Unless there is a good reason for this to stay in, with your permission, I'd like to remove that file. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#191 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQO3YCHWVMOLHHJGNVPVVN3SABHSXANCNFSM4PQ4BX7A .

Not a problem. I just removed the file from the pull request. Thanks for your work on this!

@grantfirl grantfirl merged commit 22f8341 into NCAR:master Aug 10, 2020
dustinswales pushed a commit to dustinswales/ccpp-scm that referenced this pull request May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants