Update SCM for masters of CCPP + Hera Anaconda fix#189
Merged
Conversation
Collaborator
grantfirl
commented
Jul 24, 2020
grantfirl
commented
- Update GFS_typedefs.[F90/meta] to match FV3 and to work with the latest masters of ccpp-physics and ccpp-framework
- this allows compilation of FLAKE (although it has not been tested with the SCM -- I'm not sure it can be initialized as-is)
- change module load statements for Anaconda python for Hera after machine change
…ics and ccpp-framework; include Flake variables
Collaborator
Author
|
Address #186 |
climbfuji
approved these changes
Jul 24, 2020
| Model%nrcm = 2 | ||
| !--- set nrcm | ||
|
|
||
| if (Model%ras) then |
Collaborator
There was a problem hiding this comment.
This is not new, but I assume it was forgotten when the RAS updates were brought into SCM in the first place.
Collaborator
Author
There was a problem hiding this comment.
Yes. And nobody has apparently been using RAS with the SCM to notice.
| !--- MP quantities for 3D diagnositics | ||
| real (kind=kind_phys), pointer :: refl_10cm(:,:) => null() !< instantaneous refl_10cm | ||
|
|
||
| !--- Extra PBL diagnostics |
Collaborator
There was a problem hiding this comment.
Is this a new change? Or just something we missed in an earlier update?
Collaborator
Author
There was a problem hiding this comment.
I think it was missed. Just an extra variable that wasn't hurting anything.
dustinswales
pushed a commit
to dustinswales/ccpp-scm
that referenced
this pull request
May 16, 2022
Update SCM for masters of CCPP + Hera Anaconda fix
grantfirl
added a commit
to grantfirl/ccpp-scm
that referenced
this pull request
Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.