A bug fix for wet scavenging of aerosols and a minor modification for moisture property calculation#900
Conversation
…erosols and a minor modification in moisture property calculation for the saSAS cumulus scheme
ChunxiZhang-NOAA
requested review from
JongilHan66,
SamuelTrahanNOAA,
climbfuji,
grantfirl,
mkavulich,
mzhangw and
panll
as code owners
JongilHan66
left a comment
JongilHan66
left a comment
There was a problem hiding this comment.
Changes are correct.
| cj | ||
| tem = 0.5 * (xlamue(i,k)+xlamue(i,k-1)) * dz | ||
| tem1 = 0.25 * (xlamud(i,k)+xlamud(i,k-1)) * dz | ||
| tem = 0.25 * (xlamue(i,k)+xlamue(i,k-1)) * dz |
There was a problem hiding this comment.
I am curious if the in-line SciDoc L1636 should be modified along with code change here, considering detraining parcel is not considered?
There was a problem hiding this comment.
There are 2 ways to compute a parcel property in updraft and downdraft: one is to consider only entrainment and the other is to take both entrainment and detrainment. For the former, the detrainment effect is taken into account by mass flux which is computed using entrainment and detrainment. Please see slide 4 & 8 for this PR. Note that mass flux divergence calculations are different for the former and the latter meothods. For the moisture transport, I changed the latter method to the former method in order to enhance moisture entrainment more easily (cq=1.3 in the code).
There was a problem hiding this comment.
Since only entrainment is considered to compute a parcel property in this update, the term "detraining" in Line 1636 and 1461 could be omitted.
There was a problem hiding this comment.
I don't get the "detraing" term. Please clarify.
There was a problem hiding this comment.
For example, In line 1636, the comments "...For the overshooting convection, calculate the moisture content of the entraining/detraining parcel ...". include "detraining" but the code does not use "xlamud" anymore. We want to make sure if this statement will be valid with this PR, since it will appear in CCPPv6 SciDoc.
There was a problem hiding this comment.
Since the 'detraining' effect is taken into account later in computation of mass flux divergence of moisture, I think the description is still ok.
| cj | ||
| tem = 0.5 * (xlamue(i,k)+xlamue(i,k-1)) * dz | ||
| tem1 = 0.25 * (xlamud(i,k)+xlamud(i,k-1)) * dz | ||
| tem = 0.25 * (xlamue(i,k)+xlamue(i,k-1)) * dz |
There was a problem hiding this comment.
Pls confirm if SciDoc L1461 should be modified too.
| cj | ||
| tem = 0.5 * (xlamue(i,k)+xlamue(i,k-1)) * dz | ||
| tem1 = 0.5 * xlamud(i) * dz | ||
| tem = 0.25 * (xlamue(i,k)+xlamue(i,k-1)) * dz |
| cj | ||
| tem = 0.5 * (xlamue(i,k)+xlamue(i,k-1)) * dz | ||
| tem1 = 0.5 * xlamud(i) * dz | ||
| tem = 0.25 * (xlamue(i,k)+xlamue(i,k-1)) * dz |
|
Thanks for confirming it.
…On Fri, Apr 15, 2022 at 10:43 AM JongilHan66 ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In physics/samfdeepcnv.f
<#900 (comment)>:
> @@ -1641,12 +1643,10 @@ subroutine samfdeepcnv_run (im,km,itc,ntc,cliq,cp,cvap, &
qrch = qeso(i,k)
& + gamma * dbyo(i,k) / (hvap * (1. + gamma))
cj
- tem = 0.5 * (xlamue(i,k)+xlamue(i,k-1)) * dz
- tem1 = 0.25 * (xlamud(i,k)+xlamud(i,k-1)) * dz
+ tem = 0.25 * (xlamue(i,k)+xlamue(i,k-1)) * dz
Since the 'detraining' effect is taken into account later in computation
of mass flux divergence of moisture, I think the description is still ok.
—
Reply to this email directly, view it on GitHub
<#900 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG7TW2TMXYXEF6ZAGWEEMKDVFGMCDANCNFSM5TQLMNWQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
Really great documentation of the problem and fix via the powerpoint linked in the issue, thanks! The code changes look good to me. |
5 participants
A bug fix in mass flux divergence computation for wet scavenging of aerosols and a minor modification in moisture property calculation for the saSAS cumulus scheme. Please see issue #898. This bug fix was done by Jongil Han and Kate Zhang.