Skip to content

Update sfc_ocean to accept atmosphere-ocean fluxes from external component.#894

Merged
climbfuji merged 18 commits into
NCAR:mainfrom
uturuncoglu:feature/xgrid_dev_host
Jun 9, 2022
Merged

Update sfc_ocean to accept atmosphere-ocean fluxes from external component.#894
climbfuji merged 18 commits into
NCAR:mainfrom
uturuncoglu:feature/xgrid_dev_host

Conversation

@uturuncoglu
Copy link
Copy Markdown
Contributor

This PR aims to update sfc_ocean to accept atmosphere-ocean fluxes from external component. This is tested under UFS model on NCAR's Cheyenne and all RTs are passing without any issue.

Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update your branch, I believe it's behind NCAR main (not a problem, happens all the time, but need to do when this PR gets to the top of the commit queue).

Comment thread physics/GFS_debug.F90
Comment thread physics/dcyc2.f Outdated
@uturuncoglu
Copy link
Copy Markdown
Contributor Author

@climbfuji the branch is also updated.

@uturuncoglu
Copy link
Copy Markdown
Contributor Author

This is ready to review

@grantfirl
Copy link
Copy Markdown
Collaborator

Thanks @uturuncoglu . I'll review soon. Assuming that the reviews for this and all other repos are OK, what is your preference for adding this work to the UFS merge queue?

@uturuncoglu
Copy link
Copy Markdown
Contributor Author

@grantfirl Thanks. Other PRs are still in review and I am trying to run opnReqTest for newly added RT for exchange grid work. I think ccpp/physics mods are closely related with FV3. So, I am not sure what will be the merge queue order at this point. I think after review we could wait little bit for finishing required tests.

@grantfirl
Copy link
Copy Markdown
Collaborator

grantfirl commented May 5, 2022

@grantfirl Thanks. Other PRs are still in review and I am trying to run opnReqTest for newly added RT for exchange grid work. I think ccpp/physics mods are closely related with FV3. So, I am not sure what will be the merge queue order at this point. I think after review we could wait little bit for finishing required tests.

OK. The UFS code managers operate via a bi-weekly meeting that happens to be tomorrow in order to schedule commit order. Since this is at least related to CCPP (and I'm in charge of CCPP PRs), I'll bring it up so that we may tentatively put this on the schedule for the next couple weeks. Will you be around in the next couple weeks for final testing/merging?

@uturuncoglu
Copy link
Copy Markdown
Contributor Author

@grantfirl That. That sounds fine. Yes. I'll be here for any change request.

@ChunxiZhang-NOAA
Copy link
Copy Markdown
Contributor

Thanks @uturuncoglu . I'll review soon. Assuming that the reviews for this and all other repos are OK, what is your preference for adding this work to the UFS merge queue?

@uturuncoglu I will review it soon.

Comment thread physics/GFS_PBL_generic_post.meta Outdated
Comment thread physics/GFS_PBL_generic_post.meta Outdated
Comment thread physics/sfc_ocean.meta Outdated
Comment thread physics/GFS_PBL_generic_post.meta Outdated
@grantfirl grantfirl requested a review from climbfuji May 12, 2022 19:31
@grantfirl grantfirl dismissed climbfuji’s stale review May 12, 2022 19:32

I'll make sure that this branch is updated to main before merged.

@uturuncoglu uturuncoglu requested a review from JongilHan66 as a code owner May 25, 2022 16:38
@grantfirl
Copy link
Copy Markdown
Collaborator

@uturuncoglu What is the status of this PR? Is it ready to be scheduled for commit?

@uturuncoglu
Copy link
Copy Markdown
Contributor Author

@grantfirl Sorry about the delay. There was an issue in the ORT tests but most of them is solved. I just need to make very minor modification in RT test and change one of the option there. Then, the PR will be ready to merge. It was on hold but I think it will se scheduled soon.

@uturuncoglu
Copy link
Copy Markdown
Contributor Author

@grantfirl The top level UFS PR passes all the tests and we are merging sub-components one by one. Before merging FV3, we need to merge CCPP related ones. Please let me know if you need anything from my side to merge CCPP physics and framework PRs.

@climbfuji climbfuji merged commit 1a9b050 into NCAR:main Jun 9, 2022
@climbfuji
Copy link
Copy Markdown
Collaborator

@uturuncoglu ccpp-physics PR merged. New hash is 1a9b050 for NCAR ccpp-physics main, please update your submodule pointer in fv3atm.

@uturuncoglu
Copy link
Copy Markdown
Contributor Author

uturuncoglu commented Jun 9, 2022

@climbfuji thanks. I'll update the UFS model soon.

@uturuncoglu uturuncoglu deleted the feature/xgrid_dev_host branch November 11, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants