Update sfc_ocean to accept atmosphere-ocean fluxes from external component.#894
Conversation
climbfuji
left a comment
There was a problem hiding this comment.
Please update your branch, I believe it's behind NCAR main (not a problem, happens all the time, but need to do when this PR gets to the top of the commit queue).
|
@climbfuji the branch is also updated. |
|
This is ready to review |
|
Thanks @uturuncoglu . I'll review soon. Assuming that the reviews for this and all other repos are OK, what is your preference for adding this work to the UFS merge queue? |
|
@grantfirl Thanks. Other PRs are still in review and I am trying to run |
OK. The UFS code managers operate via a bi-weekly meeting that happens to be tomorrow in order to schedule commit order. Since this is at least related to CCPP (and I'm in charge of CCPP PRs), I'll bring it up so that we may tentatively put this on the schedule for the next couple weeks. Will you be around in the next couple weeks for final testing/merging? |
|
@grantfirl That. That sounds fine. Yes. I'll be here for any change request. |
@uturuncoglu I will review it soon. |
I'll make sure that this branch is updated to main before merged.
|
@uturuncoglu What is the status of this PR? Is it ready to be scheduled for commit? |
|
@grantfirl Sorry about the delay. There was an issue in the ORT tests but most of them is solved. I just need to make very minor modification in RT test and change one of the option there. Then, the PR will be ready to merge. It was on hold but I think it will se scheduled soon. |
|
@grantfirl The top level UFS PR passes all the tests and we are merging sub-components one by one. Before merging FV3, we need to merge CCPP related ones. Please let me know if you need anything from my side to merge CCPP physics and framework PRs. |
|
@uturuncoglu ccpp-physics PR merged. New hash is 1a9b050 for NCAR ccpp-physics main, please update your submodule pointer in fv3atm. |
|
@climbfuji thanks. I'll update the UFS model soon. |
This PR aims to update sfc_ocean to accept atmosphere-ocean fluxes from external component. This is tested under UFS model on NCAR's Cheyenne and all RTs are passing without any issue.