Bring AQM model into UFS#889
Conversation
in generic physics code for PBL and surface schemes using the 'cplaqm' logical variable.
BrianCurtis-NOAA
requested review from
ChunxiZhang-NOAA,
HelinWei-NOAA,
SamuelTrahanNOAA,
climbfuji,
grantfirl,
mkavulich,
mzhangw and
panll
as code owners
|
@BrianCurtis-NOAA Is this required for any of the prototypes 8b,c? Or for CCPP v6? |
It is not required. We do want to get it committed ASAP for UFS-AQM project so we can move to our next steps. |
Thanks, will add it to the queue. The CCPPv6/P8 PRs need to go in first, however. |
| & sncovr1, qsurf, gflux, drain, evap, hflx, ep, runoff, & | ||
| & cmm, chh, evbs, evcw, sbsno, snowc, stm, snohf, & | ||
| & smcwlt2, smcref2, wet1, errmsg, errflg & | ||
| & smcwlt2, smcref2, wet1, lai, rca, errmsg, errflg & |
There was a problem hiding this comment.
Do we need to make the same change for the other two land surface models?
There was a problem hiding this comment.
There was a problem hiding this comment.
Eventually. The AQM model has only been tested with Noah.
There was a problem hiding this comment.
Noah-MP will replace Noah in all future implementations. It has been used since PT7. So I am not sure the AQM will be included in PT8. If so the same changes have to be made to Noah-MP.
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
These changes look good to me from a CCPP perspective with the caveat that @HelinWei-NOAA mentioned about connection to other LSMs in the future.
|
@HelinWei-NOAA The AQM will not be included in any of the coupled model prototypes. However, the AQM should be updated to work with NOAH MP in the next PR if not this one. |
|
@grantfirl The UFS PR has passed all RT's and CI. Ready to start merging. |
|
@BrianCurtis-NOAA Done |
6 participants
The changes here are work completed by @rmontuoro to bring AQM model into UFS.
UFS Issue: ufs-community/ufs-weather-model#1097
UFS PR: ufs-community/ufs-weather-model#1137