Split fv3atm GFS_typedefs.F90: import GFS_interstitial_type from CCPP_typedefs instead of GFS_typedefs#887
Merged
Conversation
This was referenced Mar 20, 2022
Merged
climbfuji
requested review from
ChunxiZhang-NOAA,
SamuelTrahanNOAA,
grantfirl,
mkavulich,
mzhangw and
panll
as code owners
ChunxiZhang-NOAA
approved these changes
Mar 21, 2022
…ure/split_gfs_typedefs
grantfirl
approved these changes
Mar 31, 2022
…ure/split_gfs_typedefs
…ure/split_gfs_typedefs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The host-model dependent
GFS_suite_interstitial.F90reset functions for theGFS_interstitialDDT need to importGFS_interstitial_typefromCCPP_typedefsinstead ofGFS_typedefsdue to the change in the associated fv3atm PR listed below (splitGFS_typedefs.F90).Associated fv3atm PR: NOAA-EMC/ufsatm#508
For regression testing, see ufs-community/ufs-weather-model#1130