Code update for radiation_clouds.f and GFS_rrtmg_pre.F90#858
Code update for radiation_clouds.f and GFS_rrtmg_pre.F90#858Qingfu-Liu wants to merge 3 commits into
Conversation
Qingfu-Liu
requested review from
SamuelTrahanNOAA,
climbfuji,
grantfirl and
mkavulich
as code owners
|
Regression tests not finished yet, documents also need a little more work |
|
@Qingfu-Liu |
|
Hi Dustin,
Great suggestions. I will work on those items.
Qingfu
…On Wed, Feb 9, 2022 at 5:16 PM dustinswales ***@***.***> wrote:
@Qingfu-Liu <https://github.com/Qingfu-Liu>
All of the changes look good to me. Thanks for doing this!
A few small comments/suggestion:
*) Can you output the sub-fields of "clouds" from radiation_clouds_prop?
So instead of clouds(:,:,1:10), cld_frac, cld_lwp, etc, ...
*) It might be good time to rename the progcld() routines to something
more physical? Or maybe consistent with suffixes used by the "imp_physics_"
flag?
*) Remove instances of magic numbers in cloud overlap logic? Just as for
the imp_physics_ flag, there are interstitials for each of the iovr_ and
idcor_ flags, defined in GFS_typedefs.
—
Reply to this email directly, view it on GitHub
<#858 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGTS6UXPHPBL5X2HDUHSBQTU2LRTHANCNFSM5N6T6UHA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
…agnostics.F90 and related meta files
|
Hello All, |
|
If you push your files to the remote feature/codeupdate branch, then it will update the pull request (PR). The PR is literally just a request to NCAR to pull your changes from your branch in your fork back to the "main" branch in NCAR's repository. Hence, updating your branch will update the pull request. |
|
Sam, |
|
Hi Sam,
I try to push the individual file to the remote feature/codeupdate
branch,
and got the following error message:
***@***.*** physics]$ git remote add GFS_cloud_diagnostics.F90
feature/codeupdate
fatal: remote GFS_cloud_diagnostics.F90 already exists.
***@***.*** physics]$ git push GFS_cloud_diagnostics.F90
feature/codeupdate
fatal: repository '
https://github.com/Qingfu-Liu/ccpp-physics/tree/feature/codeupdate/physics/'
not found
(by the way, I can access the http site via google browser)
What should I do?
Thank you very much.
Qingfu
…On Mon, Feb 14, 2022 at 7:55 AM Samuel Trahan (NOAA contractor) < ***@***.***> wrote:
If you push your files to the remote feature/codeupdate branch, then it
will update the pull request (PR). The PR is literally just a request to
NCAR to pull your changes from your branch in your fork back to the "main"
branch in NCAR's repository. Hence, updating your branch will update the
pull request.
—
Reply to this email directly, view it on GitHub
<#858 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGTS6UREKWRAWKZ3ZFHOG33U3D3CBANCNFSM5N6T6UHA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Wrong command. The "git remote add" will make another fork of the repository visible to your working copy. You want "git add" instead. I suggest you find a good git cheat sheet or tutorial. Gitlab has a good one: https://docs.gitlab.com/ee/gitlab-basics/start-using-git.html#add-and-commit-local-changes Also, if you're using a NOAA account, you may need to log in with ssh. This is the github page explaining how. (The process is different for gitlab.) https://docs.github.com/en/authentication/connecting-to-github-with-ssh |
|
Sam, Thank you very much. I am learning those commands. |
|
@Qingfu-Liu Are this pull request and #862 identical? If so, which do you want to keep? |
|
Hi Grant,
The two pulls are identical now. I have trouble uploading the
individual file before due to the conflicts, so I create a new pull
request. I guess we can remove the old one, and keep the new one
Qingfu
…On Tue, Feb 15, 2022 at 11:03 AM Grant Firl ***@***.***> wrote:
@Qingfu-Liu <https://github.com/Qingfu-Liu> Are this pull request and #862
<#862> identical? If so, which
do you want to keep?
—
Reply to this email directly, view it on GitHub
<#858 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGTS6UQ4NVZJRVPDBR6ZCHTU3J2MFANCNFSM5N6T6UHA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Closed in favor of #862 |
4 participants
Clear up the code of the cloud properties for radiation calculation. Changes in two program:
radiation_clouds.f
GFS_rrtmg_pre.F90