updated gwdphys.f#832
Merged
Merged
Conversation
SMoorthi-emc
requested review from
SamuelTrahanNOAA,
climbfuji,
grantfirl and
mkavulich
as code owners
|
please add Mike Toy as a reviewer |
Collaborator
Done! |
mdtoy
approved these changes
Feb 3, 2022
mdtoy
left a comment
mdtoy
left a comment
There was a problem hiding this comment.
This fixes the bug with the missing density in the mountain blocking stress equation. Looks good!
grantfirl
approved these changes
Feb 3, 2022
Collaborator
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
This looks good to me. @SMoorthi-emc did a great job making this code a bit more efficient too, judging by the multiplication substitutions and reduced arithmetic repetition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the fix for the bug reported in issue # 831