Bug fix for dimensions of eta level variables in metadata, remove duplicate Fortran modules from CMakeLists.txt#821
Merged
Conversation
…s.F90 from list of RRTMGP schemes
climbfuji
requested review from
SamuelTrahanNOAA,
grantfirl and
mkavulich
as code owners
This was referenced Dec 29, 2021
SamuelTrahanNOAA
approved these changes
Dec 29, 2021
Contributor
SamuelTrahanNOAA
left a comment
SamuelTrahanNOAA
left a comment
There was a problem hiding this comment.
Bug fixes and cleanup. Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR does two things:
SCHEMES_OPENMPinCMakeLists.txt(changes results for RRTMGP runs, because the compiler now picks the correct modules)Also included are some minor cleanups such as replacing
#ifdef OPENMPwith the standard#ifdef _OPENMPand redirecting output from schemes tostdoutinstead ofstderr.Associated PRs
#786
NOAA-EMC/ufsatm#431
ufs-community/ufs-weather-model#947
Testing
For regression testing, see ufs-community/ufs-weather-model#947