Skip to content

Modification of momentum roughness length over ice in the surface layer scheme #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
climbfuji merged 2 commits into from
Dec 23, 2021
Merged

Modification of momentum roughness length over ice in the surface layer scheme #808

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
930c037
Modification of momentum roughness length over ice in the surface lay…
wzzheng90 Dec 11, 2021
76f7e19
Modification of momentum roughness length over ice in the surface lay…
wzzheng90 Dec 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions physics/sfc_diff.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,12 +305,12 @@ subroutine sfc_diff_run (im,rvrdm1,eps,epsm1,grav, & !intent(in)
tem2 = tem1 * tem1
tem1 = one - tem2

if( ivegsrc == 1 ) then

z0max = exp( tem2*log01 + tem1*log(z0max) )
elseif (ivegsrc == 2 ) then
z0max = exp( tem2*log01 + tem1*log(z0max) )
endif
!wz if( ivegsrc == 1 ) then
!wz
!wz z0max = exp( tem2*log01 + tem1*log(z0max) )
!wz elseif (ivegsrc == 2 ) then
!wz z0max = exp( tem2*log01 + tem1*log(z0max) )
!wz endif
Comment on lines +310 to +315

@SamuelTrahanNOAA SamuelTrahanNOAA Dec 14, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented-out code should only be in the repository for a good reason. Please add a comment above the "!wz" lines giving the context. For example: what the code did, why it was removed, and what it should be replaced with. (This can be short, and only understandable by a subject matter expert.)

@wzzheng90 wzzheng90 Dec 15, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I added a comment before "!wz" lines. Thanks!!
In fact, these lines are used to calculate the effective momentum roughness length z0m proposed by Zheng et al.
(2012, https://doi.org/10.1029/2011JD015901). However, the effective z0m formulation is applied only for land, rather than for ice.
Moreover, since "shdmax" is zero over ice, these lines of code yield that z0max is actually 0.01 which is the momentum roughness length over bare soil (z0g) and not related to the ice momentum roughness length.

@SamuelTrahanNOAA SamuelTrahanNOAA Dec 16, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.


z0max = max(z0max, zmin)

Expand Down