Cleanup non-CCPP-compliant physics#79
Merged
climbfuji merged 3 commits intoMay 15, 2018
Merged
Conversation
…CHEMES.mk for CCPP build and clean up complicated tests for CCPP build in makefile
climbfuji
pushed a commit
to climbfuji/ccpp-physics
that referenced
this pull request
Feb 26, 2021
Remove inconsistencies in computation of air density with Thompson MP
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
…elop_20210331 Update gsl/develop from develop 2021/03/31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes non-CCPP-compliant physics from the code base. It also modifies the makefile (standard make, i.e. for FV3 v0) to make use of the auto-generated CCPP_SCHEMES.mk snippet and comments out blocks of code referring to non-CCPP-compliant physics in the various GFS_*_driver files for the IPD build of FV3v0.
This PR is related to and requires NCAR/ccpp-framework#65
The code compiles and produces bit-for-bit identical results with FV3v0/SCM/FV3-current trunk on Theia/Intel and MacOSX/GNU.