Bugfix in GFS_rrtmg_pre.F90: fix intent attribute of Radtend#78
Merged
Conversation
…'inout', since its components Radtend%coszen and Radtend%coszdg are updated inside coszmn. See bug report https://hwrf-rt.gsd.esrl.noaa.gov/Ticket/Display.html?id=1281
mzhangw
approved these changes
May 11, 2018
SamuelTrahanNOAA
pushed a commit
to SamuelTrahanNOAA/ccpp-physics
that referenced
this pull request
Feb 23, 2021
Update gsl/develop from master 2021/02/22
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
…-pgr-like-wrf per-timestep diagnostic output: FV3 version of WRF noise parameter
mkavulich
pushed a commit
to mkavulich/ccpp-physics
that referenced
this pull request
Jul 19, 2023
sync with the ufs/dev
mkavulich
pushed a commit
to mkavulich/ccpp-physics
that referenced
this pull request
Jul 19, 2023
land surface upgrades for HR2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actual intent of the DDT Radtend is 'inout' and not 'in', since its components Radtend%coszen and Radtend%coszdg are updated inside coszmn.
See bug report https://hwrf-rt.gsd.esrl.noaa.gov/Ticket/Display.html?id=1281.
The changes do not modify the answer on Theia with Intel or MacOSX with GNU (tested CCPP and IPD with FV3 v0).