cloud cover changes related to Thompson MP and added namelist options…#778
Conversation
|
Based on the meeting 11/19 meeting of Thompson mp developers, it is recommended that variables D0s and D0g not be made namelist options but instead that the values recommended by @RuiyuSun be hardcoded in the code, as they were deemed reasonable for applications at a range of grid spacings. There was reluctance about overexposing parameters to avoid excessive tuning. |
|
Ruiyu (and others), Also, if my test run is correct, I no longer think we need to have a namelist parameter such as In the end, it would mean only* a 3-line change to Lastly, what is with the changes to call subroutines with empty parentheses? If this isn't needed for any compiler, let's please not change code. If needed because of some change to Intel/Gnu/other, then fine. |
|
Greg,
All done.
…On Sun, Nov 21, 2021 at 11:02 AM gthompsnWRF ***@***.***> wrote:
Ruiyu (and others),
With our very promising results with D0s=300 and D0g=350, let's just
hard-wire the av_i variable to the final matching velocity at 300 micron
matching size, which would be av_i = 1493.9
Also, if my test run is correct, I no longer think we need to have a
namelist parameter such as crt_sati and could just revert to the prior
code with the inline hard-wired value of 125% (the IF-statement was ssati
.gt. 0.25).
In the end, it would mean *only** a 3-line change to
module_mp_thompson.F90
Lastly, what is with the changes to call subroutines with empty
parentheses? If this isn't needed for any compiler, let's please not change
code. If needed because of some change to Intel/Gnu/other, then fine.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#778 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKFOCLHC26EM3EXSRZM3CFTUNEJZNANCNFSM5H2VXKAQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
Ruiyu Sun, PhD
*IMSG* at NOAA/NWS/NCEP/EMC
5830 University Research Ct., Rm. 2097
College Park, MD 20740
***@***.*** ***@***.***>
301-683-3787
|
| do k = 1, NLAY | ||
| do i = 1, IX | ||
| clwf(i,k) = clw(i,k,ntcw) + clw(i,k,ntiw) + clw(i,k,ntsw) | ||
| & +clw(i,k,ntrw) + clw(i,k,ntgl) + cnvw(i,k) |
There was a problem hiding this comment.
I really don't think this is a good idea. You are now including rain + graupel + something from convection into the calculation of total condensate? The first two really shouldn't be considered in radiation or a cloud fraction scheme at all - these are not cloud particles, they are precipitation and large particles do not appreciably contribute into radiation in shortwave or longwave spectra. They are active in radiation in microwave spectra for certain, but not in here. And around line 3133, there is a subtraction of clwm from clwf, this is perhaps not what is desired.
You might consider now making changes related to this subroutine as a separate PR from the Thompson-MP changes. Furthermore, I advise you to have a look at my re-factoring of this IF-THEN-ELSE block, because I think I simplified the reading of this code far better with my changes since a good number of lines are repetitive within the IF and ELSE blocks.
There was a problem hiding this comment.
In the current radiation code, both rain and snow (optical depth) are used in cloud optics calculation in the radiative flux calculation. Graupel is considered as snow here. But its impact is small.
I can make a separate PR about the cloud change.
There was a problem hiding this comment.
Can you prove that rain is used anywhere in the radiation code? I do not believe this is true and have pondered taking out the arrays for rain from the radiation_clouds.f progcld* subroutines as they are potentially confusing to others. RRTMG should not be using rain - you can ask the authors if you wish. Also, please do not include graupel as snow. If you do, it will be setting a new precedent I think and I do not believe you will gain the support of other developers and certainly not together with the Thompson-MP. I believe it will be a detriment and cause deep convective cores of storms to turn the sky into near total darkness at the ground in shortwave radiation.
There was a problem hiding this comment.
I don't know much about the radiation code. I see rain water path is used in the following routine in cldprop in radsw_main.F90 for example.
cdat1 - real, layer cloud optical depth nlay !
.
.
cldran = cdat1(k)
.
tauran = cldran * a0r
It also used in the
rrtmg_sw_cloud_optics.F90 and rrtmgp_sw_cloud_optics.F90
I can exclude graupel from radiation. I don't think it will affect the radiative fluxes much.
| sedi_semi=sedi_semi, sedi_semi_update=sedi_semi_update, & | ||
| sedi_semi_decfl=sedi_semi_decfl, & | ||
| sedi_semi_decfl=sedi_semi_decfl, & | ||
| crt_sati=crt_sati, & |
There was a problem hiding this comment.
I think Dom has made some points about your use of indentation and continuation lines with the ampersand. Please keep things consistent.
| logical, intent(in) :: sedi_semi | ||
| logical, intent(in) :: sedi_semi_update | ||
| logical, intent(in) :: sedi_semi_decfl | ||
| real, intent(in ) :: crt_sati |
There was a problem hiding this comment.
whitespace problem - look at neighboring lines
There was a problem hiding this comment.
crt_sati namelist variable is removed from the code.
| if (mpirank==mpiroot) write(0,*) ' creating qc collision eff tables' | ||
| call table_Efrw | ||
| call table_Efsw | ||
| call table_Efsw |
There was a problem hiding this comment.
extra whitespace on the end of line
| tt=tgrs, p=prsl, w=w, dz=dz, dt_in=dtstep, dt_inner=dt_inner, & | ||
| sedi_semi=sedi_semi, sedi_semi_update=sedi_semi_update, & | ||
| sedi_semi_decfl=sedi_semi_decfl, & | ||
| sedi_semi_decfl=sedi_semi_decfl, & |
There was a problem hiding this comment.
Another stray whitespace is on the end of this line. If you use Github, it can show you these mistakes so you can detect them and fix for quicker approval.
|
|
||
| ! Call Thompson init | ||
| call thompson_init(is_aerosol_aware_in=is_aerosol_aware, mpicomm=mpicomm, & | ||
| call thompson_init(is_aerosol_aware_in=is_aerosol_aware, & |
There was a problem hiding this comment.
Ruiyu - I think you need to revert back these changes. They involve whitespace only and should not be a part of this PR as Dom suggested - unless I am mistaken on something.
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Looks good to me. Will approve when the PR has been tested with the UFS Weather Model.
|
Changes are included in #781. |
…-MP and icloud3 (cloud fraction) scheme (#1626) TYPE: enhancement KEYWORDS: microphysics, clouds, cloud fraction, Thompson microphysics SOURCE: Greg Thompson (UCAR/Joint Center for Satellite Data Assimilation) DESCRIPTION OF CHANGES: The purpose of these changes is to produce better cloud coverage and radiation amounts per tuning done with GFS global model and comparisons to observations. Problem: The Thompson-MP code (from ccpp-physics) has been used within UFS/GFS/FV-3 global model for multiple day simulations. Anning Cheng and Ruiyu Sun (NCEP/EMC) have performed most of the simulations and analysis and iterated with me to make adjustments to the Thompson-MP. At first, EMC found that high clouds were not present enough, particularly in the tropics. Once switching to a larger upper limit of cloud ice before it becomes snow, the cloud amounts improved but some clouds and radiation balances were still not matching results from FV3's GFDL microphysics (which had already been tuned to observations). Therefore an effort to account for subgrid-scale clouds using the cloud fraction scheme (icloud=3) was adopted to GFS and tested with various parameter settings. Solution: The biggest change is in how cloud ice converts to snow at a threshold size of 300 microns (up from 200 microns) and for rimed snow to convert to graupel (changed from 250 to 350 microns). A change to allowed max size of ice means that the fall velocity constant for ice was changed to keep it aligned with snow at the same cut-over size (of 300 microns). In addition, the cloud fraction scheme (icloud=3) can further improve the clouds and radiation together with Thompson-MP due to the overall under-prediction of clouds. The icloud3 option was also making far too many clouds when compared to observations so its tuning knobs were adjusted until attaining the following overall improvements compared to cloud and radiation global climatologies that EMC uses: cloud amounts of low, middle, high, and total cloud coverage, longwave radiation outgoing at top-of-atmosphere, and shortwave radiation reaching the ground. ISSUE: There are corresponding issues or pull requests in the ccpp-physics repo, [778](NCAR/ccpp-physics#778) [781](NCAR/ccpp-physics#781) [809](NCAR/ccpp-physics#809) LIST OF MODIFIED FILES: M module_mp_thompson.F M module_radiation_driver.F M module_ra_rrtmg_lw.F M module_ra_rrtmg_lwf.F M module_ra_rrtmg_sw.F M module_ra_rrtmg_swf.F TESTS CONDUCTED: 1. A series of tests in GFS including 5, 7, 16, and 30-day long simulations compared to known cloud and radiation climatologies. The plots attached here in this comment were created by Anning Cheng. The numbers at the top of each panel represent global 3-day (days 3, 4, 5) average. The first plot is the high/mid/low/total cloud amount. The tunings in this PR reduced the high cloud amount from over 55% down to the low 40s, which matches observations of global cloud coverage pretty well. And, another comparison is without the cloud fraction scheme, the mid-level clouds (and low/high) are simply less than observations, which is something well published in IPCC reports of global model clouds, especially the Southern Ocean and east sides of ocean basins (low stratus).  The next plot's panel (a) shows the outgoing longwave radiation. The target value global average is about 240 W/m2. Without the cloud fraction scheme and changes to ```D0s``` and ```D0g```, the result would be too much outgoing longwave since it will not contain enough clouds at lower temperatures. Also, the older version of the cloud fraction scheme with its excessive amount of high clouds would make the outgoing radiation closer to 225 W/m2. So the tuning of the scheme brings the results closer to observations.  Lastly, the final plot shows the downward longwave reaching the ground (panel c) and downward shortwave reaching the ground (panel d).  2. Jenkins tests are passing. RELEASE NOTE: Update of the Thompson microphysics scheme and cloud fraction scheme (icloud=3) to match the observations better. The modifications include updates to RRTMG LW and SW, and RRTMG fast LW and SW.
…-MP and icloud3 (cloud fraction) scheme (wrf-model#1626) TYPE: enhancement KEYWORDS: microphysics, clouds, cloud fraction, Thompson microphysics SOURCE: Greg Thompson (UCAR/Joint Center for Satellite Data Assimilation) DESCRIPTION OF CHANGES: The purpose of these changes is to produce better cloud coverage and radiation amounts per tuning done with GFS global model and comparisons to observations. Problem: The Thompson-MP code (from ccpp-physics) has been used within UFS/GFS/FV-3 global model for multiple day simulations. Anning Cheng and Ruiyu Sun (NCEP/EMC) have performed most of the simulations and analysis and iterated with me to make adjustments to the Thompson-MP. At first, EMC found that high clouds were not present enough, particularly in the tropics. Once switching to a larger upper limit of cloud ice before it becomes snow, the cloud amounts improved but some clouds and radiation balances were still not matching results from FV3's GFDL microphysics (which had already been tuned to observations). Therefore an effort to account for subgrid-scale clouds using the cloud fraction scheme (icloud=3) was adopted to GFS and tested with various parameter settings. Solution: The biggest change is in how cloud ice converts to snow at a threshold size of 300 microns (up from 200 microns) and for rimed snow to convert to graupel (changed from 250 to 350 microns). A change to allowed max size of ice means that the fall velocity constant for ice was changed to keep it aligned with snow at the same cut-over size (of 300 microns). In addition, the cloud fraction scheme (icloud=3) can further improve the clouds and radiation together with Thompson-MP due to the overall under-prediction of clouds. The icloud3 option was also making far too many clouds when compared to observations so its tuning knobs were adjusted until attaining the following overall improvements compared to cloud and radiation global climatologies that EMC uses: cloud amounts of low, middle, high, and total cloud coverage, longwave radiation outgoing at top-of-atmosphere, and shortwave radiation reaching the ground. ISSUE: There are corresponding issues or pull requests in the ccpp-physics repo, [778](NCAR/ccpp-physics#778) [781](NCAR/ccpp-physics#781) [809](NCAR/ccpp-physics#809) LIST OF MODIFIED FILES: M module_mp_thompson.F M module_radiation_driver.F M module_ra_rrtmg_lw.F M module_ra_rrtmg_lwf.F M module_ra_rrtmg_sw.F M module_ra_rrtmg_swf.F TESTS CONDUCTED: 1. A series of tests in GFS including 5, 7, 16, and 30-day long simulations compared to known cloud and radiation climatologies. The plots attached here in this comment were created by Anning Cheng. The numbers at the top of each panel represent global 3-day (days 3, 4, 5) average. The first plot is the high/mid/low/total cloud amount. The tunings in this PR reduced the high cloud amount from over 55% down to the low 40s, which matches observations of global cloud coverage pretty well. And, another comparison is without the cloud fraction scheme, the mid-level clouds (and low/high) are simply less than observations, which is something well published in IPCC reports of global model clouds, especially the Southern Ocean and east sides of ocean basins (low stratus).  The next plot's panel (a) shows the outgoing longwave radiation. The target value global average is about 240 W/m2. Without the cloud fraction scheme and changes to ```D0s``` and ```D0g```, the result would be too much outgoing longwave since it will not contain enough clouds at lower temperatures. Also, the older version of the cloud fraction scheme with its excessive amount of high clouds would make the outgoing radiation closer to 225 W/m2. So the tuning of the scheme brings the results closer to observations.  Lastly, the final plot shows the downward longwave reaching the ground (panel c) and downward shortwave reaching the ground (panel d).  2. Jenkins tests are passing. RELEASE NOTE: Update of the Thompson microphysics scheme and cloud fraction scheme (icloud=3) to match the observations better. The modifications include updates to RRTMG LW and SW, and RRTMG fast LW and SW.
4 participants
In the gfsv17 based Thompson MP experiments, there is significantly less cloud cover (low and high) compared with CERES data. The radiative flux biases (dsw at surface and OLR) are larger in the Thompson MP experiments than in the gfsv17 control. The purpose of the PR is to increase the cloud cover and reduce the radiative flux bias at the surface and TOA. The cloud cover formulation was modified and namelist options were added to three parameters (related to the supersaturation requirement for ice generation and D0s and D0g) in the Thompson MP to control the ice and high cloud.