Skip to content

Update several units in CCPP metadata, contains "Expanded format fields for percentages ..." (#777), update CODEOWNERS #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
climbfuji merged 10 commits into from
Nov 23, 2021
Merged

Update several units in CCPP metadata, contains "Expanded format fields for percentages ..." (#777), update CODEOWNERS #775

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
426b3fb
Replace units 'various' with 'mixed', update several invalid units of…
climbfuji Nov 10, 2021
742f01c
Expanded format fields for percentages to allow 100% to be output.
wramstrom Nov 10, 2021
62fc7f8
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into corr…
climbfuji Nov 15, 2021
415b394
Merge branch 'bugfix776' of https://github.com/wramstrom/ccpp-physics…
climbfuji Nov 15, 2021
f0cd115
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into corr…
climbfuji Nov 18, 2021
e96358c
Add @mkavulich to CODEOWNERS
climbfuji Nov 18, 2021
8c400ac
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into corr…
climbfuji Nov 23, 2021
ef072d9
Revert unnecessary whitespace changes in physics/module_mp_thompson.F90
climbfuji Nov 23, 2021
a233e2e
Change units of relative humidity variables in CCPP metadata from 1 o…
climbfuji Nov 23, 2021
b7bd5b9
Add 'in Pa' to three long names to clarify the variables
climbfuji Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

# These owners will be the default owners for everything in the repo.
#* @defunkt
* @climbfuji @llpcarson @grantfirl @mzhangw @panll
* @climbfuji @llpcarson @grantfirl @mzhangw @panll @mkavulich

# Order is important. The last matching pattern has the most precedence.
# So if a pull request only touches javascript files, only these owners
Expand Down
2 changes: 1 addition & 1 deletion physics/GFS_DCNV_generic.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@
[dtend]
standard_name = cumulative_change_of_state_variables
long_name = diagnostic tendencies for state variables
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_layer_dimension,cumulative_change_of_state_variables_outer_index_max)
type = real
kind = kind_phys
Expand Down
6 changes: 3 additions & 3 deletions physics/GFS_GWD_generic.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
[mntvar]
standard_name = statistical_measures_of_subgrid_orography_collection_array
long_name = array of statistical measures of subgrid height_above_mean_sea_level
units = various
units = mixed
dimensions = (horizontal_loop_extent,number_of_statistical_measures_of_subgrid_orography)
type = real
kind = kind_phys
Expand Down Expand Up @@ -165,7 +165,7 @@
[dtend]
standard_name = cumulative_change_of_state_variables
long_name = diagnostic tendencies for state variables
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_layer_dimension,cumulative_change_of_state_variables_outer_index_max)
type = real
kind = kind_phys
Expand Down Expand Up @@ -327,7 +327,7 @@
[dtend]
standard_name = cumulative_change_of_state_variables
long_name = diagnostic tendencies for state variables
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_layer_dimension,cumulative_change_of_state_variables_outer_index_max)
type = real
kind = kind_phys
Expand Down
2 changes: 1 addition & 1 deletion physics/GFS_MP_generic.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,7 +730,7 @@
[dtend]
standard_name = cumulative_change_of_state_variables
long_name = diagnostic tendencies for state variables
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_layer_dimension,cumulative_change_of_state_variables_outer_index_max)
type = real
kind = kind_phys
Expand Down
2 changes: 1 addition & 1 deletion physics/GFS_PBL_generic.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,7 +721,7 @@
[dtend]
standard_name = cumulative_change_of_state_variables
long_name = diagnostic tendencies for state variables
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_layer_dimension,cumulative_change_of_state_variables_outer_index_max)
type = real
kind = kind_phys
Expand Down
2 changes: 1 addition & 1 deletion physics/GFS_SCNV_generic.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@
[dtend]
standard_name = cumulative_change_of_state_variables
long_name = diagnostic tendencies for state variables
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_layer_dimension,cumulative_change_of_state_variables_outer_index_max)
type = real
kind = kind_phys
Expand Down
10 changes: 5 additions & 5 deletions physics/GFS_phys_time_vary.fv3.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@
[ozpl]
standard_name = ozone_forcing
long_name = ozone forcing data
units = various
units = mixed
dimensions = (horizontal_dimension,vertical_dimension_of_ozone_forcing_data,number_of_coefficients_in_ozone_forcing_data)
type = real
kind = kind_phys
Expand Down Expand Up @@ -157,7 +157,7 @@
[h2opl]
standard_name = stratospheric_water_vapor_forcing
long_name = water forcing data
units = various
units = mixed
dimensions = (horizontal_dimension,vertical_dimension_of_h2o_forcing_data,number_of_coefficients_in_h2o_forcing_data)
type = real
kind = kind_phys
Expand Down Expand Up @@ -1124,7 +1124,7 @@
[ozpl]
standard_name = ozone_forcing
long_name = ozone forcing data
units = various
units = mixed
dimensions = (horizontal_dimension,vertical_dimension_of_ozone_forcing_data,number_of_coefficients_in_ozone_forcing_data)
type = real
kind = kind_phys
Expand Down Expand Up @@ -1154,7 +1154,7 @@
[h2opl]
standard_name = stratospheric_water_vapor_forcing
long_name = water forcing data
units = various
units = mixed
dimensions = (horizontal_dimension,vertical_dimension_of_h2o_forcing_data,number_of_coefficients_in_h2o_forcing_data)
type = real
kind = kind_phys
Expand Down Expand Up @@ -1841,7 +1841,7 @@
[tau_amf]
standard_name = absolute_momentum_flux_due_to_nonorographic_gravity_wave_drag
long_name = ngw_absolute_momentum_flux
units = various
units = mixed
dimensions = (horizontal_dimension)
type = real
kind = kind_phys
Expand Down
10 changes: 5 additions & 5 deletions physics/GFS_phys_time_vary.scm.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@
[ozpl]
standard_name = ozone_forcing
long_name = ozone forcing data
units = various
units = mixed
dimensions = (horizontal_dimension,vertical_dimension_of_ozone_forcing_data,number_of_coefficients_in_ozone_forcing_data)
type = real
kind = kind_phys
Expand Down Expand Up @@ -157,7 +157,7 @@
[h2opl]
standard_name = stratospheric_water_vapor_forcing
long_name = water forcing data
units = various
units = mixed
dimensions = (horizontal_dimension,vertical_dimension_of_h2o_forcing_data,number_of_coefficients_in_h2o_forcing_data)
type = real
kind = kind_phys
Expand Down Expand Up @@ -1109,7 +1109,7 @@
[ozpl]
standard_name = ozone_forcing
long_name = ozone forcing data
units = various
units = mixed
dimensions = (horizontal_dimension,vertical_dimension_of_ozone_forcing_data,number_of_coefficients_in_ozone_forcing_data)
type = real
kind = kind_phys
Expand Down Expand Up @@ -1139,7 +1139,7 @@
[h2opl]
standard_name = stratospheric_water_vapor_forcing
long_name = water forcing data
units = various
units = mixed
dimensions = (horizontal_dimension,vertical_dimension_of_h2o_forcing_data,number_of_coefficients_in_h2o_forcing_data)
type = real
kind = kind_phys
Expand Down Expand Up @@ -1333,7 +1333,7 @@
[tau_amf]
standard_name = absolute_momentum_flux_due_to_nonorographic_gravity_wave_drag
long_name = ngw_absolute_momentum_flux
units = various
units = mixed
dimensions = (horizontal_dimension)
type = real
kind = kind_phys
Expand Down
2 changes: 1 addition & 1 deletion physics/GFS_rrtmg_post.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@
[fluxr]
standard_name = cumulative_radiation_diagnostic
long_name = time-accumulated 2D radiation-related diagnostic fields
units = various
units = mixed
dimensions = (horizontal_loop_extent,number_of_diagnostics_variables_for_radiation)
type = real
kind = kind_phys
Expand Down
2 changes: 1 addition & 1 deletion physics/GFS_rrtmgp_lw_post.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@
[fluxr]
standard_name = cumulative_radiation_diagnostic
long_name = time-accumulated 2D radiation-related diagnostic fields
units = various
units = mixed
dimensions = (horizontal_loop_extent,number_of_diagnostics_variables_for_radiation)
type = real
kind = kind_phys
Expand Down
2 changes: 1 addition & 1 deletion physics/GFS_rrtmgp_pre.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@
[q_lay]
standard_name = water_vapor_mixing_ratio
long_name = water vaport mixing ratio
units = kg/kg
units = kg kg-1
dimensions = (horizontal_loop_extent,vertical_layer_dimension)
type = real
kind = kind_phys
Expand Down
2 changes: 1 addition & 1 deletion physics/GFS_rrtmgp_sw_post.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@
[fluxr]
standard_name = cumulative_radiation_diagnostic
long_name = time-accumulated 2D radiation-related diagnostic fields
units = various
units = mixed
dimensions = (horizontal_loop_extent,number_of_diagnostics_variables_for_radiation)
type = real
kind = kind_phys
Expand Down
2 changes: 1 addition & 1 deletion physics/GFS_rrtmgp_thompsonmp_pre.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@
[q_lay]
standard_name = water_vapor_mixing_ratio
long_name = water vaport mixing ratio
units = kg/kg
units = kg kg-1
dimensions = (horizontal_loop_extent,vertical_layer_dimension)
type = real
kind = kind_phys
Expand Down
4 changes: 2 additions & 2 deletions physics/GFS_suite_interstitial.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,7 @@
[dtend]
standard_name = cumulative_change_of_state_variables
long_name = diagnostic tendencies for state variables
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_layer_dimension,cumulative_change_of_state_variables_outer_index_max)
type = real
kind = kind_phys
Expand Down Expand Up @@ -1768,7 +1768,7 @@
[dtend]
standard_name = cumulative_change_of_state_variables
long_name = diagnostic tendencies for state variables
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_layer_dimension,cumulative_change_of_state_variables_outer_index_max)
type = real
kind = kind_phys
Expand Down
2 changes: 1 addition & 1 deletion physics/cires_ugwp.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,7 @@
[dtend]
standard_name = cumulative_change_of_state_variables
long_name = diagnostic tendencies for state variables
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_layer_dimension,cumulative_change_of_state_variables_outer_index_max)
type = real
kind = kind_phys
Expand Down
2 changes: 1 addition & 1 deletion physics/cu_gf_driver.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@
[dtend]
standard_name = cumulative_change_of_state_variables
long_name = diagnostic tendencies for state variables
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_layer_dimension,cumulative_change_of_state_variables_outer_index_max)
type = real
kind = kind_phys
Expand Down
2 changes: 1 addition & 1 deletion physics/drag_suite.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@
[dtend]
standard_name = cumulative_change_of_state_variables
long_name = diagnostic tendencies for state variables
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_layer_dimension,cumulative_change_of_state_variables_outer_index_max)
type = real
kind = kind_phys
Expand Down
2 changes: 1 addition & 1 deletion physics/gfdl_fv_sat_adj.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@
[pkz]
standard_name = finite_volume_mean_edge_pressure_raised_to_the_power_of_kappa
long_name = finite-volume mean edge pressure raised to the power of kappa

@climbfuji climbfuji Nov 23, 2021

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here @SamuelTrahanNOAA - both standard name and long name have "finite-volume mean edge pressure raised to the power of kappa"

units = Pa**kappa
units = 1
dimensions = (starting_x_direction_index:ending_x_direction_index,starting_y_direction_index:ending_y_direction_index,1:vertical_dimension_for_fast_physics)
type = real
kind = kind_dyn
Expand Down
2 changes: 1 addition & 1 deletion physics/gwdc.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@
[dtend]
standard_name = cumulative_change_of_state_variables
long_name = diagnostic tendencies for state variables
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_layer_dimension,cumulative_change_of_state_variables_outer_index_max)
type = real
kind = kind_phys
Expand Down
2 changes: 1 addition & 1 deletion physics/h2o_def.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
[h2o_pres]
standard_name = natural_log_of_h2o_forcing_data_pressure_levels
long_name = natural log of h2o forcing data pressure levels

@climbfuji climbfuji Nov 23, 2021

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See here @SamuelTrahanNOAA - both standard name and long name have the log of ... pressure

units = log(Pa)
units = 1
dimensions = (vertical_dimension_of_h2o_forcing_data)
type = real
kind = kind_phys
4 changes: 2 additions & 2 deletions physics/h2ophys.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
[ph2o]
standard_name = natural_log_of_h2o_forcing_data_pressure_levels
long_name = natural log of h2o forcing data pressure levels
units = log(Pa)
units = 1

@climbfuji climbfuji Nov 23, 2021

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here @SamuelTrahanNOAA - both standard name and long name have the log of ... pressure

dimensions = (vertical_dimension_of_h2o_forcing_data)
type = real
kind = kind_phys
Expand All @@ -90,7 +90,7 @@
[h2opltc]
standard_name = stratospheric_water_vapor_forcing
long_name = water forcing data
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_dimension_of_h2o_forcing_data,number_of_coefficients_in_h2o_forcing_data)
type = real
kind = kind_phys
Expand Down
4 changes: 2 additions & 2 deletions physics/m_micro.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@
[mg_qcvar]
standard_name = relative_variance_of_subgrid_cloud_condensate_distribution
long_name = cloud water relative variance for MG microphysics
units =
units = frac
dimensions = ()
type = real
kind = kind_phys
Expand All @@ -151,7 +151,7 @@
[mg_rhmini]
standard_name = relative_humidity_threshold_for_ice_nucleation
long_name = relative humidity threshold parameter for nucleating ice for MG microphysics
units = none
units = frac
dimensions = ()
type = real
kind = kind_phys
Expand Down
4 changes: 2 additions & 2 deletions physics/maximum_hourly_diagnostics.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,15 +194,15 @@
[rh02max]
standard_name = maximum_relative_humidity_at_2m_over_maximum_hourly_time_interval
long_name = maximum relative humidity at 2m over maximum hourly time interval
units = %
units = frac
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
intent = inout
[rh02min]
standard_name = minimum_relative_humidity_at_2m_over_maximum_hourly_time_interval
long_name = minumum relative humidity at 2m over maximum hourly time interval
units = %
units = frac
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
Expand Down
2 changes: 1 addition & 1 deletion physics/module_MYJPBL_wrapper.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@
[dtend]
standard_name = cumulative_change_of_state_variables
long_name = diagnostic tendencies for state variables
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_layer_dimension,cumulative_change_of_state_variables_outer_index_max)
type = real
kind = kind_phys
Expand Down
2 changes: 1 addition & 1 deletion physics/module_MYNNPBL_wrapper.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1004,7 +1004,7 @@
[dtend]
standard_name = cumulative_change_of_state_variables
long_name = diagnostic tendencies for state variables
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_layer_dimension,cumulative_change_of_state_variables_outer_index_max)
type = real
kind = kind_phys
Expand Down
4 changes: 2 additions & 2 deletions physics/module_mp_thompson.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1425,7 +1425,7 @@ SUBROUTINE mp_gt_driver(qv, qc, qr, qi, qs, qg, ni, nr, nc, &
#endif
rand1, rand2, rand3, &
kts, kte, dt, i, j, ext_diag, &
sedi_semi, decfl, &
sedi_semi, decfl, &
!vtsk1, txri1, txrc1, &
prw_vcdc1, prw_vcde1, &
tpri_inu1, tpri_ide1_d, tpri_ide1_s, tprs_ide1, &
Expand Down Expand Up @@ -1821,7 +1821,7 @@ subroutine mp_thompson (qv1d, qc1d, qi1d, qr1d, qs1d, qg1d, ni1d, &
! Extended diagnostics, most arrays only
! allocated if ext_diag flag is .true.
ext_diag, &
sedi_semi, decfl, &
sedi_semi, decfl, &
!vtsk1, txri1, txrc1, &
prw_vcdc1, prw_vcde1, &
tpri_inu1, tpri_ide1_d, tpri_ide1_s, tprs_ide1, &
Expand Down
2 changes: 1 addition & 1 deletion physics/moninedmf.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@
[dtend]
standard_name = cumulative_change_of_state_variables
long_name = diagnostic tendencies for state variables
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_layer_dimension,cumulative_change_of_state_variables_outer_index_max)
type = real
kind = kind_phys
Expand Down
2 changes: 1 addition & 1 deletion physics/moninshoc.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@
[dtend]
standard_name = cumulative_change_of_state_variables
long_name = diagnostic tendencies for state variables
units = various
units = mixed
dimensions = (horizontal_loop_extent,vertical_layer_dimension,cumulative_change_of_state_variables_outer_index_max)
type = real
kind = kind_phys
Expand Down
2 changes: 1 addition & 1 deletion physics/mp_fer_hires.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@
[rhgrd]
standard_name = relative_humidity_threshold_for_condensation
long_name = relative humidity threshold parameter for condensation for FA scheme
units = none
units = frac
dimensions = ()
type = real
kind = kind_phys
Expand Down
Loading