Remove Noah-WRFv4, bug fix in Thompson MP inner loop, contains "reduce memory required by MERRA2 data" (#757)#743
Merged
climbfuji merged 18 commits intoOct 29, 2021
Conversation
…adding aerosol surface emissions, credits @tanyasmirnova
…ve-noah-wrfv4-bugfix-mp-thompson
This was referenced Sep 24, 2021
Merged
climbfuji
requested review from
JulieSchramm,
grantfirl and
llpcarson
as code owners
climbfuji
requested review from
RuiyuSun,
gthompsnWRF,
tanyasmirnova and
yangfanglin
RuiyuSun
approved these changes
Sep 24, 2021
Contributor
RuiyuSun
left a comment
RuiyuSun
left a comment
There was a problem hiding this comment.
The bug fix looks fine. Thanks!
tanyasmirnova
approved these changes
Sep 24, 2021
yangfanglin
approved these changes
Sep 24, 2021
yangfanglin
left a comment
yangfanglin
left a comment
There was a problem hiding this comment.
The developers have all agreed with removing the version of NOAH LSM inherited from HWRF, using the same NOAH LSM for all UFS application, and updating the apps to NOAH MP when it is appropriate.
…ve-noah-wrfv4-bugfix-mp-thompson
tanyasmirnova
approved these changes
Sep 27, 2021
tanyasmirnova
approved these changes
Sep 27, 2021
gthompsnWRF
approved these changes
Sep 27, 2021
Contributor
gthompsnWRF
left a comment
gthompsnWRF
left a comment
There was a problem hiding this comment.
I can only comment on the change to variable dt (dt_in) for the module_mp_thompson.F90 not the Noah-v4 removal piece. I am fine with this change. Seems quite a bit like this is a pretty important bug fix for doing inner loops.
…ve-noah-wrfv4-bugfix-mp-thompson
…ve-noah-wrfv4-bugfix-mp-thompson
…ve-noah-wrfv4-bugfix-mp-thompson
…ve-noah-wrfv4-bugfix-mp-thompson
* switch aerin and aer_pres to r*4. time and space bilinear interp will be done on r*4 variables and type promotion to r*8 will occur there
…ve-noah-wrfv4-bugfix-mp-thompson
…ve-noah-wrfv4-bugfix-mp-thompson
…ve-noah-wrfv4-bugfix-mp-thompson
…-physics into remove-noah-wrfv4-bugfix-mp-thompson
climbfuji
changed the title
…ve-noah-wrfv4-bugfix-mp-thompson
grantfirl
reviewed
Oct 29, 2021
Collaborator
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
A little late, but looks fine to me.
JohanaRomeroAlvarez
pushed a commit
to JohanaRomeroAlvarez/ccpp-physics
that referenced
this pull request
Sep 8, 2025
…rent (NCAR#743) * Modifications to replace numerous p2p transfers in fill_nested_grid_cpl by a single MPI_Bcast * Add reason for including ESMF in fv_control_init. Add code to cleanup structures associated with Bcast_comm * Get rid of unneeded mpp_sync_self * Use mpp_broadcast instead of MPI_Bcast at the request of NOAA-GFDL * Get rid of mpp pelist scoping calls in fill_nested_grid_cpl(). This depends on NOAA-GFDL/FMS#1246 to be functional. More efficient 'if' test in fill_nested_grid_cpl() * Bcast_comm and sending_proc variables not needed anymore * New member of the fv_atmos_type type called BcastMember allows more efficient determination of ranks involved in the mpp_broadcast call in fill_nested_grid_cpl routine * Port to FMS-2023.02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR contains two changes:
Fixes #734.
Fixes ufs-community/ufs-weather-model#698.
Associated PRs
#743
NOAA-EMC/ufsatm#398
ufs-community/ufs-weather-model#831
Testing
See ufs-community/ufs-weather-model#831