Fix aerosol deep convective transport (SAMF) and aerosol scavenging (RAS)#714
Merged
climbfuji merged 8 commits intoAug 13, 2021
Merged
Conversation
to compute downdraft contribution to aerosol deep convective transport. Addresses issue NCAR#709. Co-authored by Jongil Han (jongil.han@noaa.gov).
in the Relaxed Arakawa-Schubert (RAS) scheme.
rmontuoro
requested review from
JulieSchramm,
climbfuji,
grantfirl and
llpcarson
as code owners
Collaborator
|
@JongilHan66 FYI (I cannot add you as reviewer) |
chemistry tracer transported/scavenged by convection.
Contributor
|
Raffaele,
Thanks for the clarification and fix
Moorthi
…On Wed, Jul 28, 2021 at 11:31 AM Raffaele Montuoro ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In physics/rascnv.F90
<#714 (comment)>:
> @@ -402,8 +402,9 @@ subroutine rascnv_run(IM, k, itc, ntc, ntr, dt, dtf &
!
fscav_ = -999.0_kp ! By default no scavenging
if (itc > 0 .and. ntc > 0) then
- if (ntr >= itc + ntc - 3) then
- fscav_(itc:ntc) = fscav
+ n = itc + ntc - 1
+ if (n <= ntr + 2) then
+ fscav_(itc:n) = fscav
I understand the confusion, since the metadata description for itc was
inaccurate. itc is the index of the first chemistry tracer in the tracer
array provided to convective schemes.
Commit 641a45c
<641a45c>
and fv3atm PR #357 <NOAA-EMC/ufsatm#357> update
such description. Thanks, @SMoorthi-emc <https://github.com/SMoorthi-emc>,
for pointing this out!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#714 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYUWXQ4IA7DOV3UTHODT2APDJANCNFSM5BDARYOA>
.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: ***@***.***
Phone: (301) 683-3718 Fax: (301) 683-3718
|
SMoorthi-emc
approved these changes
Jul 28, 2021
This was referenced Jul 29, 2021
climbfuji
approved these changes
Aug 9, 2021
This was referenced Aug 23, 2021
JohanaRomeroAlvarez
pushed a commit
to JohanaRomeroAlvarez/ccpp-physics
that referenced
this pull request
Sep 8, 2025
…active (NCAR#714) * Add a condition to turn off samfdeepcnv when MYNN shallow convection active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a hotfix to address the following issues: