Bugfix in Thompson MP, pass correct timestep to core routine#684
Merged
climbfuji merged 3 commits intoJul 23, 2021
Merged
Conversation
This was referenced Jun 26, 2021
Closed
Collaborator
|
This bug fix looks good to me. I am looking forward to seeing which impact is has in the runs. |
junwang-noaa
approved these changes
Jun 28, 2021
grantfirl
approved these changes
Jun 28, 2021
RuiyuSun
approved these changes
Jun 28, 2021
gthompsnWRF
approved these changes
Jun 28, 2021
Contributor
gthompsnWRF
left a comment
There was a problem hiding this comment.
Same comment as Ligia! Thanks Dom.
Collaborator
Author
|
This PR seems to fix the bug of declining hydrometeors. Output from a C768L127 run, 120h forecast below. The tracer concentrations are max/min/mean.
|
…ix_thompson_pass_correct_timestep
Collaborator
Author
|
This PR has been pulled into #685 and will be merged as part of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the incorrect (full) time step was passed down to Thompson MP instead of the time step for the subcycles. This should fix the decline in precipitation that the early testing has shown (to be confirmed).
Fixes #686 .
Testing
See ufs-community/ufs-weather-model#670
Dependencies
#684
NOAA-EMC/ufsatm#334
ufs-community/ufs-weather-model#670