Skip to content

Bugfix in Thompson MP, pass correct timestep to core routine#684

Merged
climbfuji merged 3 commits into
NCAR:mainfrom
climbfuji:bugfix_thompson_pass_correct_timestep
Jul 23, 2021
Merged

Bugfix in Thompson MP, pass correct timestep to core routine#684
climbfuji merged 3 commits into
NCAR:mainfrom
climbfuji:bugfix_thompson_pass_correct_timestep

Conversation

@climbfuji
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji commented Jun 26, 2021

This PR fixes a bug where the incorrect (full) time step was passed down to Thompson MP instead of the time step for the subcycles. This should fix the decline in precipitation that the early testing has shown (to be confirmed).

Fixes #686 .

Testing

See ufs-community/ufs-weather-model#670

Dependencies

#684
NOAA-EMC/ufsatm#334
ufs-community/ufs-weather-model#670

@ligiabernardet
Copy link
Copy Markdown
Collaborator

This bug fix looks good to me. I am looking forward to seeing which impact is has in the runs.

Copy link
Copy Markdown
Contributor

@gthompsnWRF gthompsnWRF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as Ligia! Thanks Dom.

@climbfuji
Copy link
Copy Markdown
Collaborator Author

This PR seems to fix the bug of declining hydrometeors. Output from a C768L127 run, 120h forecast below. The tracer concentrations are max/min/mean.

nsub=2

   0:  sphum  2.2201141E-02  3.6418424E-08  9.2604319E-03
   0:  liq_wat  4.3379692E-03  0.0000000E+00  2.5281784E-06
   0:  ice_wat  5.1964918E-04  0.0000000E+00  1.3874734E-08
   0:  rainwat  1.1166411E-02  0.0000000E+00  3.0823865E-06
   0:  snowwat  8.4137125E-03  0.0000000E+00  2.9077935E-06
   0:  graupel  8.5209785E-03  0.0000000E+00  4.6990341E-08
   0:  water_nc  1.9372197E+09  0.0000000E+00   1475812.
   0:  ice_nc  4.5012752E+07  0.0000000E+00   949.7925
   0:  rain_nc   510593.4      0.0000000E+00   59.16530
   0:  o3mr  1.7738716E-05 -1.6795166E-09  5.6456997E-08
   0:  liq_aero  7.3091621E+10   4814625.      1.3743094E+09
   0:  ice_aero  5.7892256E+07   183.6271       1968730.
   0:  sgs_tke   205.3905      9.9245663E-05   1.082427

nsub=4

   0:  sphum  2.2648370E-02  2.8015471E-08  9.2628356E-03
   0:  liq_wat  4.3295817E-03  0.0000000E+00  2.8611310E-06
   0:  ice_wat  3.7544995E-04  0.0000000E+00  1.1459525E-08
   0:  rainwat  1.3878725E-02  0.0000000E+00  2.8739821E-06
   0:  snowwat  7.5024036E-03  0.0000000E+00  2.9518787E-06
   0:  graupel  7.0657870E-03  0.0000000E+00  4.1263071E-08
   0:  water_nc  1.9828993E+09  0.0000000E+00   1562736.
   0:  ice_nc  4.5707220E+07  0.0000000E+00   889.5925
   0:  rain_nc   542038.2      0.0000000E+00   61.62212
   0:  o3mr  1.7809110E-05 -1.6919967E-09  5.6495580E-08
   0:  liq_aero  8.7460119E+10   4268268.      1.3799584E+09
   0:  ice_aero  5.8301256E+07   262.5815       1970508.
   0:  sgs_tke   208.4773      9.9295110E-05   1.079270

@climbfuji
Copy link
Copy Markdown
Collaborator Author

This PR has been pulled into #685 and will be merged as part of it.

@climbfuji climbfuji merged commit ac38c82 into NCAR:main Jul 23, 2021
@climbfuji climbfuji deleted the bugfix_thompson_pass_correct_timestep branch June 27, 2022 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Thompson subcycling uses the wrong time step for substeps

7 participants