Add optional scaling to RRTMGP flux adjustment#668
Merged
Conversation
dustinswales
requested review from
JulieSchramm,
climbfuji,
grantfirl and
llpcarson
as code owners
This was referenced May 27, 2021
climbfuji
reviewed
May 27, 2021
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Looks pretty straightforward, just one question for my understanding.
| ! Vertical ordering? | ||
| if (p_lev(1,1) .lt. p_lev(1, levs)) then | ||
| iSFC = levs | ||
| iSFC = levs + 1 |
Collaborator
There was a problem hiding this comment.
Was that an actual bug? Is iSFC for interfaces (which is always levs+1)?
climbfuji
approved these changes
May 27, 2021
Collaborator
|
This PR has been pulled into #680 and will be merged as part of it. |
grantfirl
added a commit
that referenced
this pull request
Jul 9, 2021
Add extended diagnostic output from Thompson MP, includes "Add optional scaling to RRTMGP flux adjustment" (#668), fix index bug in m_micro.F90
JohanaRomeroAlvarez
pushed a commit
to JohanaRomeroAlvarez/ccpp-physics
that referenced
this pull request
Sep 8, 2025
…ys that are too small (NCAR#668) * move utility routines, data structures, and name generation out of FV3GFS_io.F90 * move RRFS SD state restart io to separate file and rename clm_lake_io.F90 * move rrfs sd emissions input code to FV3GFS_rrfs_sd_io.F90 * register sfc fields in FV3GFS_sfc_io.F90 * move oro reading to FV3GFS_oro_io.F90 * gwd I/O in FV3GFS_oro_io.F90 * store quilt restart data structures in FV3GFS_sfc_io types * rrfs sd restart in quilt (still under testing) * bug fixes for RRFS 32-bit physics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains improvements to how the LW heating-rate profile is updated between calls to the RRTMGP radiation scheme.
The adjusted net LW flux is computed following Hogan and Bozzo 2015 (10.1002/2015MS000455)
Optionally, the flux adjustment can be damped with height using a logistic function. This was found to be necessary when using configurations with very high/thin layers (e.g. L127). The shape of the damping function can be controlled by namelist parameters.