Feature/add templates Add templates for issues and pull requests#648
Conversation
JulieSchramm
requested review from
climbfuji,
grantfirl and
llpcarson
as code owners
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Thanks for creating those templates! A few small changes, otherwise good to go. Will need to include in one of the next ufs-weather-model PRs.
| One or more paragraphs describing the problem, solution, and required changes. | ||
|
|
||
| ## Tests Conducted: | ||
| Explicitly state what tests were run on these changes, or if any are still pending (for README or other text-only changes, just put "None required". Make note of the compilers used, the platform/machine, and other relevant details as necessary. For more complicated changes, or those resulting in scientific changes, please be explicit! |
There was a problem hiding this comment.
We should add language here to alternatively refer to parent PRs (e.g. SCM and/or UFS PRs), since those ask for the same information. Typically, we add the testing information to the top-level PR (ccpp-scm, ufs-weather-model) and it is unnecessary to repeat the information here,
| Add any links to tests conducted. For example, "See ufs-community/ufs-weather-model/pull/<pr_number>" | ||
|
|
||
| ## Dependencies: | ||
| Add any links to parent PRs. For example: |
There was a problem hiding this comment.
It's not only parent PRs, some PRs (e.g. rte-rrtmgp) have the ccpp-physics PR as parent.
|
|
||
| ## Tests Conducted: | ||
| Explicitly state what tests were run on these changes, or if any are still pending (for README or other text-only changes, just put "None required". Make note of the compilers used, the platform/machine, and other relevant details as necessary. For more complicated changes, or those resulting in scientific changes, please be explicit! | ||
| Add any links to tests conducted. For example, "See ufs-community/ufs-weather-model/pull/<pr_number>" |
There was a problem hiding this comment.
Picky, but I would say information (as you had in your original text) OR links to tests conducted.
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Looks good to me, thanks! We'll merge this in the near future, and then we need to do the same for ccpp-framework and ccpp-doc.
|
@JulieSchramm could you take these PR/issue templates and create a similar PR for ccpp-framework? This way I don't have to steal your work. I am hoping to get the template PRs committed early/mid next week. Thanks! |
|
Yes, I will do this tomorrow morning. |
* update dycore: semi-implicit solver update
2 participants
Addresses issue #633