Accumulation of RRTMGP development#614
Merged
Merged
Conversation
…between timesteps.
… addLWadj_fullProfile
… logical variable
RRTMGP w/o OpenMP
…d LW Jacobian from RRTMGP flux adjustement.
dustinswales
requested review from
JulieSchramm,
climbfuji,
grantfirl and
llpcarson
as code owners
This was referenced Apr 9, 2021
…Avoids error when k-distribution file does not contain these fields.
climbfuji
requested changes
Apr 27, 2021
| set (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${OpenMP_C_FLAGS}") | ||
| set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${OpenMP_CXX_FLAGS}") | ||
| set (CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} ${OpenMP_Fortran_FLAGS}") | ||
| #set (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${OpenMP_C_FLAGS}") |
Collaborator
There was a problem hiding this comment.
Note. @DusanJovic-NOAA and I are currently working on a cleanup of the compiler flag settings in CMakeLists.txt, very much needed as you can tell from working with this mess yourself. Hopefully it will be easier to turn off OpenMP for the RRTMGP files listed below in the future.
Qingfu-Liu
approved these changes
Apr 27, 2021
climbfuji
reviewed
Apr 28, 2021
climbfuji
approved these changes
Apr 28, 2021
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
PR looks good to me. Changes to CMakeLists.txt make the existing mess even messier, but this will be rewritten entirely in the near future.
llpcarson
approved these changes
Apr 28, 2021
tanyasmirnova
approved these changes
Apr 28, 2021
…work when symlinks are in the path
Update Cmakelists.txt so that it works with symlinks in compile path
HelinWei-NOAA
pushed a commit
to HelinWei-NOAA/ccpp-physics
that referenced
this pull request
Feb 26, 2023
* Six new winter wx diags added to output, accumulated fields added to restart file and changed nsradar_reset, radar_reset to something that makes more sense, that is, nsfullradar_diag and fullradar_diag. Also, added new namelist parameter to use new precip ice density with the NOAH LSM. Code changes to upp also made to include the new winter wx diags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains several fixes and improvements to RRTMGP and its coupling to the Thompson microphysics.
Edit from @climbfuji:
FV3/ccpp/physics/CMakeLists.txtwere ignored