Skip to content

Fix bugs in the pre-rad to have correct radii and radiation fluxes #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
climbfuji merged 3 commits into from
Feb 19, 2021
Merged

Fix bugs in the pre-rad to have correct radii and radiation fluxes #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0467d63
Fix bugs in the pre-rad to have correct radii and radiation fluxes
RuiyuSun Feb 10, 2021
336876d
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into ru…
RuiyuSun Feb 17, 2021
8cc60d3
a bug fix in radiation_clouds.f for Thompson MP
RuiyuSun Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions physics/GFS_rrtmg_pre.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ subroutine GFS_rrtmg_pre_run (im, levs, lm, lmk, lmp, n_var_lndp, &
plyr(i,k1) = prsl(i,k2) * 0.01 ! pa to mb (hpa)
tlyr(i,k1) = tgrs(i,k2)
prslk1(i,k1) = prslk(i,k2)
rho(i,k1) = plyr(i,k1)/(con_rd*tlyr(i,k1))
rho(i,k1) = prsl(i,k2)/(con_rd*tlyr(i,k1))
orho(i,k1) = 1.0/rho(i,k1)

!> - Compute relative humidity.
Expand Down Expand Up @@ -774,7 +774,7 @@ subroutine GFS_rrtmg_pre_run (im, levs, lm, lmk, lmp, n_var_lndp, &
!tgs: progclduni has different limits for ice radii (10.0-150.0) than
! calc_effectRad (4.99-125.0 for WRFv3.8.1; 2.49-125.0 for WRFv4+)
! it will raise the low limit from 5 to 10, but the high limit will remain 125.
call calc_effectRad (tlyr(i,:), plyr(i,:), qv_mp(i,:), qc_mp(i,:), &
call calc_effectRad (tlyr(i,:), plyr(i,:)*100., qv_mp(i,:), qc_mp(i,:), &
nc_mp(i,:), qi_mp(i,:), ni_mp(i,:), qs_mp(i,:), &
re_cloud(i,:), re_ice(i,:), re_snow(i,:), 1, lm )
end do
Expand Down
2 changes: 1 addition & 1 deletion physics/radiation_clouds.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3189,7 +3189,7 @@ subroutine progcld6 &
endif

! Call subroutine get_alpha_exp to define alpha parameter for exponential cloud overlap options
if ( iovr == 4 .or. iovr == 5) then
if ( iovr == 3 .or. iovr == 4 .or. iovr == 5) then
call get_alpha_exp(ix, nLay, dzlay, de_lgth, alpha)
else
de_lgth(:) = 0.
Expand Down