You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR contains a snippet of code to apply a bounds check on the layer temperature provided to RRTMGP.
RRTMGP reports an error and quits when out of range temperatures are provided. This was discovered to occur in the upper atmosphere when using 127 vertical layers.
Dustin,
Could you please explain in more detail the change you made ? Is the temperature being reset to a T_min if it is smaller than T_min (160K) ? If so, this temporary fix needs to be updated at the earliest possible.
if (t_lay(iCol,iLay) .le. lw_gas_props%get_temp_min()) then
t_lay = lw_gas_props%get_temp_min() + epsilon(lw_gas_props%get_temp_min())
endif
Dustin,
Could you please explain in more detail the change you made ? Is the temperature being reset to a T_min if it is smaller than T_min (160K) ? If so, this temporary fix needs to be updated at the earliest possible.
if (t_lay(iCol,iLay) .le. lw_gas_props%get_temp_min()) then
t_lay = lw_gas_props%get_temp_min() + epsilon(lw_gas_props%get_temp_min())
endif
@yangfanglin
You're correct.
The temperature is set to the lowest value allowed in RRTMGP, lw_gas_props%get_temp_min(), for cases with temperatures lower.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a snippet of code to apply a bounds check on the layer temperature provided to RRTMGP.
RRTMGP reports an error and quits when out of range temperatures are provided. This was discovered to occur in the upper atmosphere when using 127 vertical layers.