Skip to content

Added lower limit to temperature used by RRTMGP.#548

Merged
climbfuji merged 2 commits into
NCAR:masterfrom
dustinswales:master-9c73d96-addTempBounds
Jan 20, 2021
Merged

Added lower limit to temperature used by RRTMGP.#548
climbfuji merged 2 commits into
NCAR:masterfrom
dustinswales:master-9c73d96-addTempBounds

Conversation

@dustinswales
Copy link
Copy Markdown
Member

This PR contains a snippet of code to apply a bounds check on the layer temperature provided to RRTMGP.

RRTMGP reports an error and quits when out of range temperatures are provided. This was discovered to occur in the upper atmosphere when using 127 vertical layers.

@yangfanglin
Copy link
Copy Markdown

Dustin,
Could you please explain in more detail the change you made ? Is the temperature being reset to a T_min if it is smaller than T_min (160K) ? If so, this temporary fix needs to be updated at the earliest possible.

if (t_lay(iCol,iLay) .le. lw_gas_props%get_temp_min()) then
t_lay = lw_gas_props%get_temp_min() + epsilon(lw_gas_props%get_temp_min())
endif

@dustinswales
Copy link
Copy Markdown
Member Author

Dustin,
Could you please explain in more detail the change you made ? Is the temperature being reset to a T_min if it is smaller than T_min (160K) ? If so, this temporary fix needs to be updated at the earliest possible.

if (t_lay(iCol,iLay) .le. lw_gas_props%get_temp_min()) then
t_lay = lw_gas_props%get_temp_min() + epsilon(lw_gas_props%get_temp_min())
endif

@yangfanglin
You're correct.
The temperature is set to the lowest value allowed in RRTMGP, lw_gas_props%get_temp_min(), for cases with temperatures lower.

@climbfuji
Copy link
Copy Markdown
Collaborator

@dustinswales I added it to the commit queue, hope to get this in soon.

@climbfuji
Copy link
Copy Markdown
Collaborator

@dustinswales Can you confirm whether an update of the rrtmgp-rte submodule pointer is required or not?

@dustinswales
Copy link
Copy Markdown
Member Author

@climbfuji
No update needed to the rte-rrtmgp submodule.

@climbfuji climbfuji merged commit 13b8889 into NCAR:master Jan 20, 2021
@dustinswales dustinswales deleted the master-9c73d96-addTempBounds branch February 16, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants