Minor bug fixes to unified_ugwp.F90 and drag_suite.F90#532
Merged
Conversation
mdtoy
requested review from
JulieSchramm,
climbfuji,
grantfirl and
llpcarson
as code owners
Author
|
I forgot to mention: Thanks to Valery Yudin for finding these two bugs. |
climbfuji
approved these changes
Dec 16, 2020
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Approved. Will merge once the regression testing is completed.
…ified_ugwp_bugfix Merging unified_ugwp bug fixes.
HelinWei-NOAA
pushed a commit
to HelinWei-NOAA/ccpp-physics
that referenced
this pull request
Feb 26, 2023
* Changes to ccpp to support 32-bit physics in NRL Neptune model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed two bugs:
unified_ugwp.F90 -- the variables oa4ss and ol4ss are now correctly declared with dimensions (im,4). Since these variables were just "passing through" unified_ugwp.F90 to get to the drag_suite_run subroutine, this bug had not effected the actual run-time results. The results before and after the bug fix are bit-to-bit identical.
drag_suite.F90 -- removed division by the dimensionless Exner function, which was appropriate for the WRF model theta-tendency, but not for the FV3GFS model TEMPERATURE tendency.
Fixes #533 (add one-liner regarding licenses in specific files overriding the overall Apache license).
Associated PRs:
#532
NOAA-EMC/ufsatm#216
These PRs will be tested together with ufs-community/ufs-weather-model#319, for regression testing information see there.