Radiation lw/sw pre/post routine name changes, optional arguments#45
Merged
climbfuji merged 2 commits intoFeb 26, 2018
Merged
Conversation
…adiation; check for presence of optional cloud fields, depending on cloud method used
climbfuji
requested review from
grantfirl,
ligiabernardet,
llpcarson and
mzhangw
mzhangw
approved these changes
Feb 26, 2018
climbfuji
deleted the
gmtb-gfsphysics-radiation-arguments-and-scheme-names
branch
climbfuji
pushed a commit
to climbfuji/ccpp-physics
that referenced
this pull request
Sep 2, 2020
Updates and bug fix for MYNN surface layer scheme
SamuelTrahanNOAA
pushed a commit
to SamuelTrahanNOAA/ccpp-physics
that referenced
this pull request
Aug 11, 2022
Updated Flake physics and modified related files
lisa-bengtsson
pushed a commit
to lisa-bengtsson/ccpp-physics
that referenced
this pull request
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issues with optional versus mandatory arguments to the radiation lw/sw routines and changes the names of several of the pre/post routines. The presence of optional arguments is checked inside the routine, depending on the cloud method.
This PR goes together with NCAR/ccpp-framework#28 and https://github.com/NCAR/gmtb-fv3/pull/33.