Remove dynamic CCPP build#439
Merged
Merged
Conversation
climbfuji
force-pushed
the
remove_ccpp_dynamic_build
branch
from
9f7e1c8 to
a66d980
Compare
This was referenced Apr 21, 2020
climbfuji
requested review from
JulieSchramm,
grantfirl and
llpcarson
as code owners
Collaborator
Author
|
@llpcarson @grantfirl we are hoping to merge this today, tomorrow or latest on Friday. Please review. @JulieSchramm @ligiabernardet once this is merged, we can work on the follow-up documentation update. Thanks! |
Collaborator
|
Tks for the reminder. @julie Schramm <schramm@ucar.edu> is
already preparing the documentation.
…On Wed, Apr 22, 2020 at 7:32 AM Dom Heinzeller ***@***.***> wrote:
@llpcarson <https://github.com/llpcarson> @grantfirl
<https://github.com/grantfirl> we are hoping to merge this today,
tomorrow or latest on Friday. Please review. @JulieSchramm
<https://github.com/JulieSchramm> @ligiabernardet
<https://github.com/ligiabernardet> once this is merged, we can work on
the follow-up documentation update. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#439 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE7WQAVI3FKCAC5B63DH7BDRN3WU7ANCNFSM4MM5OIBA>
.
|
llpcarson
approved these changes
Apr 22, 2020
Contributor
llpcarson
left a comment
llpcarson
left a comment
There was a problem hiding this comment.
Looks good to me, approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR and associated PRs below completely remove the dynamic CCPP from the ufs-weather-model and all its submodules.
Associated PRs:
NOAA-EMC/GFDL_atmos_cubed_sphere#18
NCAR/ccpp-framework#287
#439
NOAA-EMC/ufsatm#103
NOAA-EMC/NEMS#54
ufs-community/ufs-weather-model#107
For regression testing information, see ufs-community/ufs-weather-model#107.