Cleanup SCM build#426
Merged
Merged
Conversation
climbfuji
requested review from
JulieSchramm,
grantfirl and
llpcarson
as code owners
grantfirl
approved these changes
Apr 3, 2020
Collaborator
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
Looks fine to me. Thanks.
This was referenced Apr 3, 2020
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
NCAR#426) The semi-Lagrangian sedimentation of graupel is added. The namelist variables controlling the semi-Lagrangian sedimentation of precipitation (rain and graupel) are modified. Now SEDI_SEMI and DECFL is the switch. DECFL is the deformed CFL factor. Semi-Lagrangian sedimentation of precipitation is added as an option and does not change results before it is turned on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unneeded build code for SCM, including an unintentionally left
message(FATAL_ERROR ...)exceptionAfter merging this PR, the submodule pointer in UFS' fv3atm should be updated, too (no testing required, all code changes are inside
if (PROJECT STREQUAL "CCPP-SCM")blocks.Tested together with NCAR/ccpp-scm#179; this ccpp-physics PR #426 must be merged first, and the submodule pointer must be updated in the gmtb-scm PR NCAR/ccpp-scm#179.