Coupled stochy fixes for precipitation#416
Conversation
Update my fork with NCAR's master
pjpegion
requested review from
JulieSchramm,
climbfuji,
grantfirl and
llpcarson
as code owners
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Straightforward changes, made consistently in fv3atm and ccpp-physics. I am approving it, but we merging will require coordination with the ufs-weather-model commit queue. I assume this will change the results for the fv3_stochy/fv3_ccpp_stochy tests?
|
@climbfuji This does not change the current regression test since it only is an issue with the coupled model, and the regression tests are not running anything coupled yet. |
Of course - I should have known. |
|
Update 03/24/2020: this PR has been pulled into #417 and will be merged automatically as part of it. No need to close this PR, it will be flagged as merged automatically. |
…effective radii computation from Thompson MP" and "Fix/improve logic for convective transportable tracers, add GFS_checktracer debugging routine, correct spelling "janic" --> "janjic", fix inconsistent types related with noahmp and log functions" (NCAR#416) * Add missing active attribute for one variable in ccpp/data/GFS_typedefs.meta * Correct spelling of janic in CCPP standard names, must be janjic * Remove invalid optional and intent attributes from DDT metadata in ccpp/data/GFS_typedefs.meta * Remove support for optional arguments from CCPP framework/metadata
2 participants
The pull request references #415, there was an inconsistency between the partition of the rain and snow and the rain/snow tendency that was later perturbed as part of SPPT.
The update to GFS_MP_generic.F90 makes these consistent.