HWRF Ferrier-Aligo MP scheme updates

[mzhangw]

This PR passed full RTs.
rt_full.log

This PR is HWRF Ferrier-Aligo MP scheme updates of @ericaligo-NOAA, @ChunxiZhang-NOAA and @mzhangw , which includes:

• cloud fraction and optical property calculation
• FA scientific documentation
• proper tracer update and PBL mixing

The associated PR is
NCAR/fv3atm#28
NCAR/ufs-weather-model#25

[climbfuji]

@mzhangw, cc @grantfirl @ligiabernardet, not sure what to do with this PR. The commit history is completely off, I am showing 70+ commits with 12 changed files. The history goes back to July 1, 2019.

Also, I see changes in files that you have overwritten in the meanwhile, for example in physics/GFS_rrtmg_pre.F90. The current code in branch dtc/hwrf-physics is, after your HWRF RRTMG code went in:

...
        elseif(Model%imp_physics == 15) then
          if (Model%kdt == 1) then
            Tbd%phy_f3d(:,:,Model%nleffr) = 10.
            Tbd%phy_f3d(:,:,Model%nieffr) = 50.
            Tbd%phy_f3d(:,:,Model%nseffr) = 250.
          endif

          call progcld5 (plyr,plvl,tlyr,tvly,qlyr,qstl,rhly,tracer1,    &  !  --- inputs
                         Grid%xlat,Grid%xlon,Sfcprop%slmsk,dz,delp,     &
                         ntrac-1, ntcw-1,ntiw-1,ntrw-1,                 &
                         ntsw-1,ntgl-1,                                 &
                         im, lmk, lmp, Model%icloud,Model%uni_cld,      &
                         Model%lmfshal,Model%lmfdeep2,                  &
                         cldcov(:,1:LMK),Tbd%phy_f3d(:,:,1),            &
                         Tbd%phy_f3d(:,:,2), Tbd%phy_f3d(:,:,3),        &
                         clouds,cldsa,mtopa,mbota, de_lgth)            !  --- outputs

        endif                            ! end if_imp_physics
...

but in this PR, I am seeing

...
        elseif(Model%imp_physics == 15) then
           call progcld2 (plyr,plvl,tlyr,qlyr,qstl,rhly,tvly,tracer1,&  !  --- inputs
                          Grid%xlat,Grid%xlon,Sfcprop%slmsk,dz,delp, &
                          ntrac-1, ntcw-1,ntiw-1,ntrw-1,             &
                          im, lmk, lmp,                              &
                          Model%lmfshal,Model%lmfdeep2,              &
                          clouds,cldsa,mtopa,mbota, de_lgth)            !  --- outputs
 !  ---  output
...

So ... which is correct?

[mzhangw]

FA updates PR was committed before HWRF RRTMG, in which I (after consulting with you )decided to use progcld5 for FA, so progcld6 was left for GSD suite. Progcld2 in FA PR is legacy program for Ferrier scheme, we do not call it anymore when FA is interfaced with HWRF RRTMG. I think that other changes in this PR are straightforward.

[climbfuji]

Ok, I am sorry but I need you to work on this PR, I cannot take it like it is.

Please let me know if you want to start from scratch by doing a manual comparison with what is in dtc/hwrf-physics now and come up with a replacement PR (and close the current PR), or try to update the current PR. Thanks!

[mzhangw]

I just merged dtc/hwrf-physics into this PR.

…

On Apr 13, 2020, at 8:11 PM, Dom Heinzeller ***@***.***> wrote: Ok, I am sorry but I need you to work on this PR, I cannot take it like it is. Please let me know if you want to start from scratch by doing a manual comparison with what is in dtc/hwrf-physics now and come up with a replacement PR (and close the current PR), or try to update the current PR. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#405 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG7TW2V3QVNF5BMRNBAYP6DRMPA55ANCNFSM4LF2TKVA>.

[climbfuji]

I just merged dtc/hwrf-physics into this PR.
…

I see, thanks. The commit history is dirty. But I could merge/squash your branch, will create the PR that sits on top of yours and see what the actual diffs are.

[climbfuji]

This PR has been merged (with the commit history squashed) into #435 for target branch dtc/hwrf-physics. Once #435 gets merged, this PR can be closed.

[mzhangw]

Thanks! As @ligiabernardet suggested, this PR, before merged with dtc/hwrf-physics, can be treated as a bug fix of FA. It should go to master too.

…

On Apr 13, 2020, at 8:35 PM, Dom Heinzeller ***@***.***> wrote: I just merged dtc/hwrf-physics into this PR. … <x-msg://193/#> I see, thanks. The commit history is dirty. But I could merge/squash your branch, will create the PR that sits on top of yours and see what the actual diffs are. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#405 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG7TW2RMKDLFO4GAS6WUQKDRMPDVZANCNFSM4LF2TKVA>.

[climbfuji]

Well, given that it somehow depends on the HWRF RRTMG progcld5 changes, it can only go to master once HWRF RRTMG goes to master - which is when dtc/hwrf-physics goes to master.

[climbfuji]

This PR has been pulled into #435 and will be merged to dtc/hwrf-physics first, later to master. Therefore closing this PR.